Skip to content

update workflow to pass jobname to python-control pytest #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnavigator merged 3 commits into from
Dec 29, 2022
Merged

update workflow to pass jobname to python-control pytest #190

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68565e7
update workflow to pass jobname to python-control pytest
murrayrm Dec 25, 2022
23c0093
add quotes to JOBNAME expansion
murrayrm Dec 26, 2022
73f575e
add build type to JOBNAME
murrayrm Dec 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/slycot-build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,9 @@ jobs:
pip install slycot-wheels/${{ matrix.packagekey }}/slycot*.whl
pip show slycot
- name: Slycot and python-control tests
run: bash slycot-src/.github/scripts/run-tests.sh
run: JOBNAME=$JOBNAME bash slycot-src/.github/scripts/run-tests.sh

@bnavigator bnavigator Dec 25, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised that this works without quotes around $JOBNAME as there is a space in the value.

env:
JOBNAME: ${{ matrix.packagekey }} ${{ matrix.blas_lib }}
- name: report coverage
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down Expand Up @@ -359,7 +361,9 @@ jobs:
mamba install -c ./slycot-conda-pkgs slycot
conda list
- name: Slycot and python-control tests
run: bash slycot-src/.github/scripts/run-tests.sh
run: JOBNAME=$JOBNAME bash slycot-src/.github/scripts/run-tests.sh
env:
JOBNAME: ${{ matrix.packagekey }} ${{ matrix.blas_lib }}
- name: Report coverage
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down