Skip to content

Update Slycot to use LAPACK 3.6.x + #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
murrayrm merged 22 commits into from
Jan 13, 2018
Merged

Update Slycot to use LAPACK 3.6.x + #13

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2d9a253
adapting slycot to newer LAPACK:
repagh Jun 10, 2017
c1cb581
add an explicit return of ZERO in functions that have alternative
repagh Jun 10, 2017
062585b
fix setup.py abiver detection for python 2.7
repagh Jun 10, 2017
b36bfeb
set flags for lib building
repagh Jun 10, 2017
e25e65f
fix typos
repagh Jun 10, 2017
cb147c9
removed trailing whitespace
repagh Jun 11, 2017
81ebab4
removed working comment
repagh Jun 11, 2017
651ce07
add a test case for sg03ad
repagh Jun 15, 2017
e69c54f
added a test case for sg02ad, ricatti eqn solving
repagh Jun 19, 2017
115ee1c
import linalg from numpy, not scipy
repagh Jun 19, 2017
8cf5e49
reverting the ZLATZM -> ZUNMRZ change, adding SLYCOT specific ZLATZM
repagh Jun 24, 2017
a627f9e
need blas as lib for build on Mac OSX
repagh Jun 24, 2017
25eb04d
testing with openblas??
repagh Jun 28, 2017
8b7e1e3
crazy stuff
Jul 10, 2017
dd7b4b0
revert last 2 edits that should not have gone on master
repagh Jul 19, 2017
9ce23a8
windows build config, with mingw32
Oct 9, 2017
3b7c763
remove local build hack
Oct 9, 2017
92f588c
finally a working recipe for windows build
Oct 9, 2017
080d214
finally a working recipe for windows build
repagh Oct 9, 2017
74d3d83
Merge branch 'winwork' of https://github.com/repagh/Slycot into winwork
repagh Oct 9, 2017
8f93896
Merge remote branch 'origin/winwork'
repagh Oct 9, 2017
bc52eaa
branching linux/osx build conda recipe into proper script
repagh Oct 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typos
  • Loading branch information
@repagh
repagh committed Jun 10, 2017
commit e25e65fc235a89fcce070085110fb5d829aeffa7
2 changes: 1 addition & 1 deletion conda-recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ build:

script:
- cd $RECIPE_DIR/..
- DFLAGS="-shared" FFLAGS=-fPIC $PYTHON setup.py install # [not win]
- LDFLAGS="-shared" FFLAGS=-fPIC $PYTHON setup.py install # [not win]

@roryyorke roryyorke Jun 11, 2017

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this is required? "-shared" and "-fPIC" are standard enough that I would think the build tools we're using (distutils, setuptools, conad) would set them.

@repagh repagh Jun 11, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know why, but it would not "conda build" build without, I tried both on OSX and Linux. Tomorrow I can fire up a virtualbox with windows, and see what conda build does there

@repagh repagh Jun 11, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this works, I will try to get slycot + control in conda-forge

There might be something in the build tools that is not set right, but I don't know where to look for that.

@roryyorke roryyorke Jun 11, 2017

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed this and the setup.py mods from your branch here; passing Travis CI results here.


requirements:
build:
Expand Down