Call by reference in ab13bd #199

Activity

1. KybernetikJo commented on Jul 19, 2023

   

   KybernetikJo

   on Jul 19, 2023

   ContributorAuthor

   More actions

   def h2norm_slycot_c(A,B,C,D):
       dico = 'C'
       jobn = 'H'
   
       n, m = B.shape
       p, _ = C.shape
   
       #a = A.copy()
       #b = B.copy()
       #c = C.copy()
       #d = D.copy()
   
       a = A
       b = B
       c = C
       d = D
   
       h2norm = 0
       h2norm = slycot.ab13bd(dico, jobn, n, m, p, a, b, c, d)
       return h2norm
   
   A1 = np.array([[0.0, 1.0],[-0.5, -0.1]])
   B1 = np.array([[0.],[1.]])
   C1 = np.eye(2)
   D1 = np.zeros((2,1))
   
   print(h2norm_slycot_c(A1,B1,C1,D1))
   print(h2norm_slycot_c(A1,B1,C1,D1))
   print(h2norm_slycot_c(A1,B1,C1,D1))
   
   # 3.872983346207419
   # 3.838232974288851
   # 3.7856002470901817

   Fix, shallow copy

   def h2norm_slycot_c(A,B,C,D):
       dico = 'C'
       jobn = 'H'
   
       n, m = B.shape
       p, _ = C.shape
   
       a = A.copy()
       b = B.copy()
       c = C.copy()
       d = D.copy()
   
       #a = A
       #b = B
       #c = C
       #d = D
   
       h2norm = 0
       h2norm = slycot.ab13bd(dico, jobn, n, m, p, a, b, c, d)
       return h2norm
   
   A1 = np.array([[0.0, 1.0],[-0.5, -0.1]])
   B1 = np.array([[0.],[1.]])
   C1 = np.eye(2)
   D1 = np.zeros((2,1))
   
   print(h2norm_slycot_c(A1,B1,C1,D1))
   print(h2norm_slycot_c(A1,B1,C1,D1))
   print(h2norm_slycot_c(A1,B1,C1,D1))
   
   # 3.872983346207419
   # 3.872983346207419
   # 3.872983346207419
2. roryyorke commented on Jul 22, 2023

   

   roryyorke

   on Jul 22, 2023

   Collaborator

   More actions

   For future readers: see #200 for further discussion.
3. roryyorke

   added a commit that references this issue on Jul 22, 2023

   Regression test for python-controlgh-199: ab13md should not change it…

   ...

   0277e72
4. bnavigator commented on Aug 26, 2023

   

   bnavigator

   on Aug 26, 2023

   Collaborator

   More actions

   Closed by #200, the general issue is still open.
5. bnavigator

   closed this as completedon Aug 26, 2023