Skip to content

Fix most tests on Python 3.13 #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 5 commits into from
May 10, 2024
Merged

Fix most tests on Python 3.13 #378

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ccf1cf0
Fix most tests on Python 3.13
AlexWaygood May 10, 2024
959b36f
lint
AlexWaygood May 10, 2024
d2aa92a
.
AlexWaygood May 10, 2024
ecd8b8e
make NoDefault immutable
AlexWaygood May 10, 2024
24bff62
rework the skips
AlexWaygood May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make NoDefault immutable
  • Loading branch information
@AlexWaygood
AlexWaygood committed May 10, 2024
commit ecd8b8e311a072a0ad23151fd23693c332d5e98b
8 changes: 8 additions & 0 deletions src/test_typing_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6300,6 +6300,14 @@ def test_no_call(self):
with self.assertRaises(TypeError):
NoDefault()

@skipIf(
sys.version_info[:5] == (3, 13, 0, "beta", 1),
"incorrectly raises TypeError in the first 3.13 beta"
)

@AlexWaygood AlexWaygood May 10, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened python/cpython#118895

def test_immutable(self):
with self.assertRaises(AttributeError):
NoDefault.foo = 'bar'


class TypeVarInferVarianceTests(BaseTestCase):
def test_typevar(self):
Expand Down
2 changes: 2 additions & 0 deletions src/typing_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,6 +1361,8 @@ def TypeAlias(self, parameters):
NoDefault = typing.NoDefault
else:
class NoDefaultType:
__slots__ = ()

def __new__(cls):
return globals().get("NoDefault") or object.__new__(cls)

Expand Down