Skip to content

Fix isinstance() with generic protocol subclasses after subscripting #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 2 commits into from
Aug 22, 2019
Merged

Fix isinstance() with generic protocol subclasses after subscripting #669

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a75292e
Fix isinstance() with generic protocol subclasses after subscripting
Aug 22, 2019
4b9dfcf
Tweak comment
Aug 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Tweak comment
  • Loading branch information
Ivan Levkivskyi
Ivan Levkivskyi committed Aug 22, 2019
commit 4b9dfcf1a984865de78ca18b41178f60c6177ebf
2 changes: 1 addition & 1 deletion python2/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1394,7 +1394,7 @@ def __getitem__(self, params):
def __subclasscheck__(self, cls):
if self.__origin__ is not None:
# These should only be modules within the standard library.
# singledispatch is the only exception, because it's a Python 2 backport
# singledispatch is an exception, because it's a Python 2 backport
# of functools.singledispatch.
whitelist = ['abc', 'functools', 'singledispatch']
if (sys._getframe(1).f_globals['__name__'] in whitelist or
Expand Down