Skip to content

Add AsyncContextManager generic class #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 7 commits into from
Jun 9, 2017
Merged

Add AsyncContextManager generic class #438

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2f00d3e
Add AsyncContextManager
ilevkivskyi Jun 9, 2017
dffa255
Fix lint and underscore
Jun 9, 2017
2cbdb1b
A real fix of import
Jun 9, 2017
cd137de
Only import on newer versions
Jun 9, 2017
d0eea94
Inline _check_methods on Python 3.5 similar to AsyncIterator
Jun 9, 2017
8b19224
Fix whitespace
Jun 9, 2017
1283d70
Add a test that shows how to use AsyncContextManager (and two more te…
Jun 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
A real fix of import
  • Loading branch information
Ivan Levkivskyi
Ivan Levkivskyi committed Jun 9, 2017
commit 2cbdb1b07754b6cc3128c47e3e090b1cb76710fd
3 changes: 2 additions & 1 deletion src/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import collections.abc as collections_abc
except ImportError:
import collections as collections_abc # Fallback for PY3.2.
import _collections_abc # Needed for private function _check_methods
try:
from types import WrapperDescriptorType, MethodWrapperType, MethodDescriptorType
except ImportError:
Expand Down Expand Up @@ -1996,7 +1997,7 @@ async def __aexit__(self, exc_type, exc_value, traceback):
@classmethod
def __subclasshook__(cls, C):
if cls is AsyncContextManager:
return collections_abc._check_methods(C, "__aenter__", "__aexit__")
return _collections_abc._check_methods(C, "__aenter__", "__aexit__")
return NotImplemented

__all__.append('AsyncContextManager')
Expand Down