Skip to content

Protocols #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ilevkivskyi wants to merge 19 commits into from
Closed

Protocols #417

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
de21b02
Initial ideas for runtime implementation of protocols
ilevkivskyi Apr 19, 2017
6a31a93
Uniform class and instance checks (same as collections.abc)
ilevkivskyi Apr 23, 2017
f107299
Fix lint
ilevkivskyi Apr 23, 2017
8e07b88
Simplify code using absence of non-protocol bases + some support for …
ilevkivskyi Apr 23, 2017
e3db3de
Better support for isinstance(); add some tests
ilevkivskyi Apr 24, 2017
e580511
Minor fixes
ilevkivskyi Apr 24, 2017
d99d9ef
Add more tests; improve docstrings
ilevkivskyi Apr 24, 2017
831e1a7
Add support for extending collections protocols (+ tests)
ilevkivskyi Apr 24, 2017
a932e9f
Fix behaviour in different veriosns
ilevkivskyi Apr 24, 2017
3e34f7a
More compatibility fixes
ilevkivskyi Apr 24, 2017
8483810
Fix typos and lint
ilevkivskyi Apr 24, 2017
9e7b674
Even more compatibility fixes
ilevkivskyi Apr 24, 2017
8ee5b71
Reorganize code more logically (hopefully this will also reduce diff)
Apr 25, 2017
4a0d335
Add tests for PY36 and @abstracmethod
ilevkivskyi Apr 25, 2017
8fc9a5e
Backport protocols to Python 2
ilevkivskyi Apr 25, 2017
b6e526e
Corner case for PEP 526 subprotocols
ilevkivskyi Apr 26, 2017
d3a5491
Add test for named tuple with protocol
ilevkivskyi May 13, 2017
eecef84
Merge branch 'master' into protocols
ilevkivskyi Jul 28, 2017
904c978
Fix broken merge
ilevkivskyi Jul 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into protocols
  • Loading branch information
@ilevkivskyi
ilevkivskyi authored Jul 28, 2017
commit eecef84c3eb14d85cb8dc7c1cd5ebd140fc995b6
2 changes: 1 addition & 1 deletion python2/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ def _type_check(arg, msg):
if (
type(arg).__name__ in ('_Union', '_Optional') and
not getattr(arg, '__origin__', None) or
isinstance(arg, TypingMeta) and _gorg(arg) in (Generic, Protocol)
isinstance(arg, TypingMeta) and arg._gorg in (Generic, Protocol)
):
raise TypeError("Plain %s is not valid as type argument" % arg)
return arg
Expand Down
2 changes: 1 addition & 1 deletion src/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ def _type_check(arg, msg):
if (
type(arg).__name__ in ('_Union', '_Optional') and
not getattr(arg, '__origin__', None) or
isinstance(arg, TypingMeta) and _gorg(arg) in (Generic, Protocol)
isinstance(arg, TypingMeta) and arg._gorg in (Generic, Protocol)
):
raise TypeError("Plain %s is not valid as type argument" % arg)
return arg
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.