Skip to content

Optimize ABC caches #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 8 commits into from
Feb 10, 2017
Merged

Optimize ABC caches #383

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
313ca43
Optimize ABC negative cache for generics
Feb 1, 2017
6382c8a
Add also positive cache and registry links
Feb 1, 2017
6d1bcf2
Formatting
Feb 1, 2017
c464731
Add ABC optimization to PY2
Feb 1, 2017
423fb75
Inline internal helper for more speed
Feb 1, 2017
f998e24
Fix negative cahce setters
ilevkivskyi Feb 2, 2017
9444b53
Fix negative cahce setters on PY2
ilevkivskyi Feb 2, 2017
0ca5c0b
Make negative caches writable only for non-subscripted generics
ilevkivskyi Feb 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix negative cahce setters on PY2
  • Loading branch information
@ilevkivskyi
ilevkivskyi committed Feb 4, 2017
commit 9444b535def9900f34fd48993f57395547716c44
6 changes: 4 additions & 2 deletions python2/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1084,7 +1084,8 @@ def _abc_negative_cache(self):
def _abc_negative_cache(self, value):
if isinstance(self.__extra__, abc.ABCMeta):
self.__extra__._abc_negative_cache = value
_gorg(self)._abc_generic_negative_cache = value
else:
_gorg(self)._abc_generic_negative_cache = value

@property
def _abc_negative_cache_version(self):
Expand All @@ -1096,7 +1097,8 @@ def _abc_negative_cache_version(self):
def _abc_negative_cache_version(self, value):
if isinstance(self.__extra__, abc.ABCMeta):
self.__extra__._abc_negative_cache_version = value
_gorg(self)._abc_generic_negative_cache_version = value
else:
_gorg(self)._abc_generic_negative_cache_version = value

def _get_type_vars(self, tvars):
if self.__origin__ and self.__parameters__:
Expand Down