Skip to content

New backward-compatible NamedTuple #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 7 commits into from
Sep 11, 2016
Merged

New backward-compatible NamedTuple #282

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9e191fb
New backward-compatible NamedTuple
ilevkivskyi Sep 11, 2016
e2dad0f
Minor refactoring
ilevkivskyi Sep 11, 2016
6e4525d
Fixed for older Python 3 versions
ilevkivskyi Sep 11, 2016
6352eae
Fixed typo
ilevkivskyi Sep 11, 2016
ce6aa0d
Fixed unordered dict
ilevkivskyi Sep 11, 2016
170408d
Fixed one more typo
ilevkivskyi Sep 11, 2016
11b6940
Fixed one more typo
ilevkivskyi Sep 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed unordered dict
  • Loading branch information
@ilevkivskyi
ilevkivskyi committed Sep 11, 2016
commit ce6aa0da7e2de1f1ae4dfd4d064a47eeca5ce79a
9 changes: 4 additions & 5 deletions src/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1802,7 +1802,7 @@ def new_user(user_class: Type[U]) -> U:


def _make_nmtuple(name, types):
nm_tpl = collections.namedtuple(name, [n for n in types])
nm_tpl = collections.namedtuple(name, [n for n, t in types])
nm_tpl._field_types = types
try:
nm_tpl.__module__ = sys._getframe(2).f_globals.get('__name__', '__main__')
Expand All @@ -1818,7 +1818,7 @@ def __new__(cls, typename, bases, ns, *, _root=False):
if _root:
return super().__new__(cls, typename, bases, ns)
types = ns.get('__annotations__', {})
return _make_nmtuple(typename, types)
return _make_nmtuple(typename, types.items())

class NamedTuple(metaclass=NamedTupleMeta, _root=True):
"""Typed version of namedtuple.
Expand All @@ -1842,8 +1842,7 @@ class Employee(NamedTuple):
"""

def __new__(self, typename, fields):
types = dict(fields)
return _make_nmtuple(typename, types)
return _make_nmtuple(typename, fileds)
else:
def NamedTuple(typename, fields):
"""Typed version of namedtuple.
Expand All @@ -1861,7 +1860,7 @@ def NamedTuple(typename, fields):
are in the _fields attribute, which is part of the namedtuple
API.)
"""
return _make_nmtuple(typename, dict(fields))
return _make_nmtuple(typename, fields)


def NewType(name, tp):
Expand Down