Skip to content

Attempt to clarify the ByteString situation #9783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 10 commits into from
May 28, 2023
Merged

Attempt to clarify the ByteString situation #9783

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4ad291f
Attempt to clarify the ByteString situation
hauntsaninja Feb 20, 2023
24fd3c0
.
hauntsaninja Feb 20, 2023
4dcbddc
add back collections abc ..... for now .........
hauntsaninja Feb 20, 2023
2ec5f71
.
hauntsaninja Feb 20, 2023
3a16bd6
allowlist
hauntsaninja Feb 20, 2023
ab33068
allowlist
hauntsaninja Feb 20, 2023
12b8bb5
comment
hauntsaninja Feb 20, 2023
ee57021
Fix flake8
AlexWaygood Feb 21, 2023
2217fff
Update tests/stubtest_allowlists/py3_common.txt
hauntsaninja May 8, 2023
ddb9997
Merge branch 'main' into byte-string
JelleZijlstra May 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Attempt to clarify the ByteString situation 
See python/cpython#102092

This makes the behaviour of typing.ByteString better match its
documentation.

I also remove collections.abc.ByteString. There is no legitimate use
case for it. Let me know if you think there's a case where it would help
users to have this around.
  • Loading branch information
@hauntsaninja
hauntsaninja committed Feb 20, 2023
commit 4ad291f42fd9624cd187f596748cc9df47f2e35f
1 change: 0 additions & 1 deletion stdlib/_collections_abc.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ from typing import ( # noqa: Y022,Y038
AsyncIterable as AsyncIterable,
AsyncIterator as AsyncIterator,
Awaitable as Awaitable,
ByteString as ByteString,
Callable as Callable,
Collection as Collection,
Container as Container,
Expand Down
2 changes: 1 addition & 1 deletion stdlib/typing.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ class TextIO(IO[str]):
@abstractmethod
def __enter__(self) -> TextIO: ...

class ByteString(Sequence[int], metaclass=ABCMeta): ...
ByteString = bytes | bytearray | memoryview

# Functions

Expand Down