Skip to content

Update comments post #5768 #9527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 2 commits into from
Jan 14, 2023
Merged

Update comments post #5768 #9527

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c2613f
Update numpy and 5768 comments
Avasam Jan 14, 2023
17da551
Update comments
Avasam Jan 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update comments
  • Loading branch information
@Avasam
Avasam committed Jan 14, 2023
commit 17da551f64afa41f5a2eae4e015c7469f9e5e6db
2 changes: 1 addition & 1 deletion stubs/Pillow/@tests/stubtest_allowlist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PIL.FpxImagePlugin
PIL.ImageQt.ImageQt
PIL.MicImagePlugin
# Requires Pyside or PyQt to be installed.
# Requires PySide or PyQt to be installed.
# We don't install either in stubtest so it can't see it
PIL.ImageQt.QImage
PIL.ImageQt.QPixmap
2 changes: 1 addition & 1 deletion stubs/PyScreeze/pyscreeze/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ _R = TypeVar("_R")
# https://github.com/microsoft/python-type-stubs/tree/main/cv2
# https://github.com/opencv/opencv/pull/20370
# cv2.Mat is just an alias for a numpy NDArray, but can't import that either.
# Because pyscreeze does not declare it as a dependency, stubsuploader won't let it.
# Because pyscreeze does not declare it as a dependency, stub_uploader won't let it.
_Mat: TypeAlias = Incomplete

useOpenCV: bool
Expand Down
2 changes: 1 addition & 1 deletion stubs/pycocotools/pycocotools/coco.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ from typing_extensions import Literal, TypeAlias, TypedDict

from . import _EncodedRLE

# stub_uploader doesn't allow numpy because pycocotools doesn't declare it as a dependency
# TODO: Use numpy types when #5768 is resolved.
# import numpy as np
# import numpy.typing as npt

Expand Down
2 changes: 1 addition & 1 deletion stubs/pycocotools/pycocotools/cocoeval.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ from typing_extensions import Literal, TypeAlias, TypedDict

from .coco import COCO

# stub_uploader doesn't allow numpy because pycocotools doesn't declare it as a dependency
# TODO: Use numpy types when #5768 is resolved.
# import numpy as np
# import numpy.typing as npt

Expand Down
2 changes: 1 addition & 1 deletion stubs/pycocotools/pycocotools/mask.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ from typing_extensions import TypeAlias

from . import _EncodedRLE

# stub_uploader doesn't allow numpy because pycocotools doesn't declare it as a dependency
# TODO: Use numpy types when #5768 is resolved.
# import numpy as np
# import numpy.typing as npt

Expand Down