Skip to content

Fix issue #9296 (calling register on KeysView subclass causes false positive error) #9348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 5 commits into from
Dec 10, 2022
Merged

Fix issue #9296 (calling register on KeysView subclass causes false positive error) #9348

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7df48a8
Revert "`Collection` is `Sized` (#8977)"
jab Dec 10, 2022
c9ae4f9
Revert "typing: remove metaclass from Sized (#9058)"
jab Dec 10, 2022
69e36c1
Add regression test for issue 9296.
jab Dec 10, 2022
17a8e5f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 10, 2022
8a329ba
Update stdlib/builtins.pyi
JelleZijlstra Dec 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add regression test for issue 9296.
  • Loading branch information
@jab
jab committed Dec 10, 2022
commit 69e36c1b988e54e129402973a6e23c508ed615a2
18 changes: 18 additions & 0 deletions test_cases/stdlib/typing/check_regression_issue_9296.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
from __future__ import annotations

import typing as t


KT = t.TypeVar("KT")


class MyKeysView(t.KeysView[KT]):
pass


d: dict[t.Any, t.Any] = {}
dict_keys = type(d.keys())

# This should not cause an error like `Member "register" is unknown`:
MyKeysView.register(dict_keys)