Skip to content

Fix typings of ExceptionGroup and BaseExceptionGroup #9230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 13 commits into from
Nov 23, 2022
Merged

Fix typings of ExceptionGroup and BaseExceptionGroup #9230

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3412cdd
Fix typings of `ExceptionGroup` and `BaseExceptionGroup`
sobolevn Nov 20, 2022
d6090ed
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 20, 2022
4e37a93
only in 3.11
JelleZijlstra Nov 20, 2022
5daa26c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 20, 2022
9c06c0a
Address review
sobolevn Nov 21, 2022
0eaf7b8
Fix pyright
sobolevn Nov 21, 2022
7e57c9c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 21, 2022
aba41b9
Fix flake8
sobolevn Nov 21, 2022
7416e6a
Fix flake8
sobolevn Nov 21, 2022
caccf63
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 21, 2022
7c6735b
Merge remote-tracking branch 'upstream/main' into issue-9219
AlexWaygood Nov 21, 2022
93a4638
Add the magic suffix to the test-case filename
AlexWaygood Nov 21, 2022
8828619
Merge branch 'main' into issue-9219
AlexWaygood Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix flake8
  • Loading branch information
@sobolevn
sobolevn committed Nov 21, 2022
commit 7416e6ae0b3096557acaa7fc25accf3bccd675f6
2 changes: 0 additions & 2 deletions .flake8
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ per-file-ignores =
# https://github.com/PyCQA/flake8/issues/1079
# F811 redefinition of unused '...'
stdlib/typing.pyi: B, E301, E302, E305, E501, E701, E741, NQA102, F401, F403, F405, F811, F822, Y037
# `ExceptionGroup` and `BaseExceptionGroup` are not recognised as builtins yet:
test_cases/stdlib/builtins/check_exception_group.py: F821, E203, E301, E302, E305, E501
# Generated protobuf files include docstrings
*_pb2.pyi: B, E301, E302, E305, E501, E701, NQA102, Y021, Y026

Expand Down
4 changes: 4 additions & 0 deletions test_cases/stdlib/builtins/check_exception_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
from typing_extensions import assert_type

if sys.version_info >= (3, 11):
# This can be removed later, but right now `flake8` does not know
# about these two classes:
from builtins import BaseExceptionGroup, ExceptionGroup

# BaseExceptionGroup
# ==================

Expand Down