Skip to content

socketserver: improve bytes handling #9096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 14 commits into from
Jan 12, 2023
Merged

socketserver: improve bytes handling #9096

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3f4fd9c
socketserver: improve bytes handling
JelleZijlstra Nov 5, 2022
e6d4802
use _RetAddress (which is Any, shhh)
JelleZijlstra Nov 5, 2022
51b6f69
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 5, 2022
da9d3e8
fix http.server
JelleZijlstra Nov 5, 2022
d610470
Merge branch 'main' into socketserver
JelleZijlstra Jan 12, 2023
6aa1e52
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 12, 2023
dc9c7da
Feedback from Alex
JelleZijlstra Jan 12, 2023
360e1cf
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 12, 2023
2b40731
ignore
JelleZijlstra Jan 12, 2023
59fc621
Update server.pyi
AlexWaygood Jan 12, 2023
bb8aacb
One more nit
AlexWaygood Jan 12, 2023
29478d0
oops
AlexWaygood Jan 12, 2023
4e81d85
Merge branch 'main' into socketserver
AlexWaygood Jan 12, 2023
578f8d2
consistent server_address
JelleZijlstra Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
One more nit
  • Loading branch information
@AlexWaygood
AlexWaygood authored Jan 12, 2023
commit bb8aacb5afda2b176e5dab91dbd35fcb53cb83b1
12 changes: 6 additions & 6 deletions stdlib/socketserver.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ _AfInetAddress: TypeAlias = tuple[str | bytes | bytearray, int] # address accep
# This can possibly be generic at some point:
class BaseServer:
address_family: int
server_address: tuple[str, int]
server_address: tuple[int, int]
socket: _socket
allow_reuse_address: bool
request_queue_size: int
Expand Down Expand Up @@ -137,14 +137,14 @@ if sys.platform != "win32":
class ThreadingUnixDatagramServer(ThreadingMixIn, UnixDatagramServer): ...

class BaseRequestHandler:
# Those are technically of types, respectively:
# * _RequestType
# * _RetAddress
# But there are some concerns that having unions here would cause
# `request` is technically of type _RequestType,
# but there are some concerns that having a union here would cause
# too much inconvenience to people using it (see
# https://github.com/python/typeshed/pull/384#issuecomment-234649696)
#
# Note also that _RetAddress is also just an alias for `Any`
request: Any
client_address: Any
client_address: _RetAddress
server: BaseServer
def __init__(self, request: _RequestType, client_address: _RetAddress, server: BaseServer) -> None: ...
def setup(self) -> None: ...
Expand Down