Skip to content

typing: accept buffers in typing.IO.write #9084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JelleZijlstra wants to merge 17 commits into from
Closed

typing: accept buffers in typing.IO.write #9084

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2f87ea0
typing: accept buffers in typing.IO.write
JelleZijlstra Nov 4, 2022
e940cdf
type ignore
JelleZijlstra Nov 4, 2022
8d82f82
need this way
JelleZijlstra Nov 4, 2022
5aacf0a
fix arg name
JelleZijlstra Nov 4, 2022
9293f5e
Merge branch 'main' into typing
JelleZijlstra Nov 10, 2022
717e864
Merge branch 'main' into typing
AlexWaygood Feb 8, 2023
2894148
Update lzma.pyi
AlexWaygood Feb 8, 2023
6532cd4
Merge branch 'main' into typing
AlexWaygood Feb 9, 2023
642f843
Merge remote-tracking branch 'upstream/main' into typing
JelleZijlstra Mar 10, 2023
641511b
Remove references to closed mypy issue
JelleZijlstra Mar 10, 2023
590851b
Adjust overloads to work with pyright
JelleZijlstra Mar 10, 2023
b6174cb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 10, 2023
92c2606
ignore another
JelleZijlstra Mar 10, 2023
7f10fc8
no picklebuffer in 3.7
JelleZijlstra Mar 10, 2023
684b4ee
into the uncertain future
JelleZijlstra Mar 10, 2023
bd78b5b
maybe help mypy primer
JelleZijlstra Mar 10, 2023
37bb27e
try the other way
JelleZijlstra Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
typing: accept buffers in typing.IO.write 
Fixes #9082
  • Loading branch information
@JelleZijlstra
JelleZijlstra committed Nov 4, 2022
commit 2f87ea0c8c898a434d110ff44e942f56ab244233
8 changes: 6 additions & 2 deletions stdlib/typing.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import _typeshed
import collections # Needed by aliases like DefaultDict, see mypy issue 2986
import sys
from _collections_abc import dict_items, dict_keys, dict_values
from _typeshed import IdentityFunction, Incomplete, SupportsKeysAndGetItem
from _typeshed import IdentityFunction, Incomplete, ReadableBuffer, SupportsKeysAndGetItem
from abc import ABCMeta, abstractmethod
from contextlib import AbstractAsyncContextManager, AbstractContextManager
from re import Match as Match, Pattern as Pattern
Expand Down Expand Up @@ -671,7 +671,11 @@ class IO(Iterator[AnyStr], Generic[AnyStr]):
@abstractmethod
def writable(self) -> bool: ...
@abstractmethod
def write(self, __s: AnyStr) -> int: ...
@overload
def write(self: IO[str], __s: str) -> int: ...
@abstractmethod
@overload
def write(self: IO[bytes], __s: ReadableBuffer) -> int: ...
@abstractmethod
def writelines(self, __lines: Iterable[AnyStr]) -> None: ...
@abstractmethod
Expand Down