Skip to content

http.server.SimpleHTTPRequestHandler: Fix version branching #9075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 1 commit into from
Nov 3, 2022
Merged

http.server.SimpleHTTPRequestHandler: Fix version branching #9075

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
http.server.SimpleHTTPRequestHandler: Fix version branching 
The stub currently implies that the index_pages parameter has been removed in 3.12. Actually, it was only added in 3.12 :)

See python/cpython#31985. (This is a follow-up to #9055 — cc. @JelleZijlstra.)
  • Loading branch information
@AlexWaygood
AlexWaygood authored Nov 3, 2022
commit 05267dd02ba9bd282d68fe3887bfaee8c70d4445
2 changes: 1 addition & 1 deletion stdlib/http/server.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ class SimpleHTTPRequestHandler(BaseHTTPRequestHandler):
server: socketserver.BaseServer,
*,
directory: str | None = ...,
index_pages: Sequence[str] | None = ...,
) -> None: ...
else:
def __init__(
Expand All @@ -68,7 +69,6 @@ class SimpleHTTPRequestHandler(BaseHTTPRequestHandler):
server: socketserver.BaseServer,
*,
directory: str | None = ...,
index_pages: Sequence[str] | None = ...,
) -> None: ...

def do_GET(self) -> None: ...
Expand Down