Repository navigation
Itertools stubtest exception fixes / adjustments - #5211
Merged
Merged
Conversation
hatal175
commented
Apr 12, 2021
hatal175
commented
Contributor
- Fixed itertools stubtest exceptions
- Mostly classes defined as functions (see Functions that are actually classes #5145)
- Did not fix product and combinations due to Tuple mypy issues. see Incompatible return type for overlapping signatures with regards to __new__ mypy#10313
- Tried to make count more accurate as it technically can accept anything that passes PyNumber_Check and has add. There also isn't a need to tie the start and step together type-wise.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: sphinx (https://github.com/sphinx-doc/sphinx.git)
+ sphinx/pycode/parser.py: note: In member "add_entry" of class "VariableCommentPicker":
+ sphinx/pycode/parser.py:252:50: error: Incompatible types in assignment (expression has type "SupportsComplex", target has type "int")
+ sphinx/pycode/parser.py: note: At top level:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.