Skip to content

Add more consistency tests #4983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 12 commits into from
Jan 29, 2021
Merged

Add more consistency tests #4983

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1c1e3ac
Add more consistency tests
Jan 28, 2021
608f19f
Typos and fixes
Jan 28, 2021
6b393b5
Fix lint
Jan 28, 2021
2f2478f
Add check for VERSIONS
Jan 29, 2021
d6bd3de
Add check for METADATA.toml
Jan 29, 2021
0f16c2c
Fixes
Jan 29, 2021
e1df4fd
Use f-strings
Jan 29, 2021
dc5e17c
Better error messages
Jan 29, 2021
9a5c68b
Fix dependency
Jan 29, 2021
d295597
Only check versions for 3 and 2and3 modules
Jan 29, 2021
beccc25
Actually run metadata tests
Jan 29, 2021
3419ac3
Fix space
Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint
  • Loading branch information
Ivan Levkivskyi
Ivan Levkivskyi committed Jan 28, 2021
commit 6b393b53905953bb783494a9d0a322162f9a196c
2 changes: 1 addition & 1 deletion tests/check_consistent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def assert_stubs_only(directory):
"""Check that given directory contains only valid stub files."""
top = directory.split(os.sep)[-1]
assert top.isidentifier(), "Bad directory name: {}".format(top)
for root, dirs, files in os.walk(directory):
for _, dirs, files in os.walk(directory):
for file in files:
name, ext = os.path.splitext(file)
assert name.isidentifier(), "Files must be valid modules"

@JelleZijlstra JelleZijlstra Jan 28, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add the name to the assertion failure to make the failure more debuggable. Same for a number of other checks below.

(Also, is there a reason not to use f-strings here?)

Expand Down