Skip to content

[types] Make MethodType generic #15993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 16 commits into from
Oct 20, 2026
Merged

[types] Make MethodType generic #15993

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
67b69c5
[types] Make `MethodType` generic
srittau Jul 10, 2026
059ab2f
Merge branch 'main' into generic-method-type
srittau Aug 5, 2026
f63d5f2
Merge remote-tracking branch 'upstream/main' into generic-method-type
srittau Sep 10, 2026
b065fac
Add a test case
srittau Sep 10, 2026
81abee5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 10, 2026
f65e9c0
Add a second test
srittau Sep 10, 2026
d80c633
Add a third test case
srittau Sep 10, 2026
0d703e5
Work around pyright bug
srittau Sep 10, 2026
f5f525c
Add another test
srittau Sep 10, 2026
473e3d0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 10, 2026
40d28e0
Fix type
srittau Sep 10, 2026
55b96c5
Add missing import
srittau Sep 10, 2026
202ab99
finagle
srittau Sep 10, 2026
d86d4aa
special handling necessary
srittau Sep 10, 2026
1b0fcdc
preposition
srittau Sep 10, 2026
57683e0
special handling required
srittau Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
finagle
  • Loading branch information
@srittau
srittau committed Sep 10, 2026
commit 202ab99790a9b1e43a67ae0f7badabccbcf7802d
2 changes: 1 addition & 1 deletion stdlib/@tests/test_cases/check_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@
return x


def fake_method(self: MethodTypeTest, x: int) -> int:
def fake_method(self: MethodTypeTest, /, x: int) -> int:
return x


bound_method1 = MethodTypeTest().method
assert isinstance(bound_method1, types.MethodType)
assert_type(bound_method1(42), int)

Check failure on line 25 in stdlib/@tests/test_cases/check_types.py

View workflow job for this annotation

GitHub Actions / pyright: regression tests (Linux, 3.13) 

"assert_type" mismatch: expected "int" but received "Unknown" (reportAssertTypeFailure)

bound_method2 = types.MethodType(MethodTypeTest.method, MethodTypeTest())
assert isinstance(bound_method2, types.MethodType)
Expand Down
3 changes: 2 additions & 1 deletion stdlib/types.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,8 @@ class MethodType(Generic[_P_default, _R_default]):
def __name__(self) -> str: ... # inherited from the added function
@property
def __qualname__(self) -> str: ... # inherited from the added function
def __new__(cls, func: Callable[Concatenate[object, _P_default], _R_default], instance: object, /) -> Self: ...
# First func argument is usually "self".
def __new__(cls, func: Callable[Concatenate[Any, _P_default], _R_default], instance: object, /) -> Self: ...
def __call__(self, *args: _P_default.args, **kwargs: _P_default.kwargs) -> _R_default: ...

if sys.version_info >= (3, 13):
Expand Down
Loading