Skip to content

Change cache/lru_cache typing to retain function signatures #12945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alwaysmpe wants to merge 15 commits into from
Closed

Change cache/lru_cache typing to retain function signatures #12945

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5ca2ed5
Change `cache`/`lru_cache` typing to retain function signatures
alwaysmpe Nov 3, 2024
c16b351
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 3, 2024
833e40e
Fix remove overload implementation
alwaysmpe Nov 3, 2024
6e22af9
Fix add version gate for `typing.Concatenate`
alwaysmpe Nov 3, 2024
ab29e6d
Fix match mypy's expected type invariance
alwaysmpe Nov 3, 2024
3cbb714
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 3, 2024
91f43a2
Fix copy/paste mistake
alwaysmpe Nov 3, 2024
54e4fe0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 3, 2024
fd0d180
Fix cache should be positional-only
alwaysmpe Nov 3, 2024
3aaf0ff
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 3, 2024
8c5c469
Remove what I think are nolonger needed ignores
alwaysmpe Nov 3, 2024
28e87fc
Fix final shouldn't have been removed
alwaysmpe Nov 3, 2024
1d1c46a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 3, 2024
d705819
Use type invariance recommended by pyright (which I think is correct)
alwaysmpe Nov 3, 2024
6af9214
Various improvements
alwaysmpe Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix cache should be positional-only
  • Loading branch information
@alwaysmpe
alwaysmpe committed Nov 3, 2024
commit fd0d180e957347fd7280a7e9fa70bbb8ef86c3c2
6 changes: 3 additions & 3 deletions stdlib/functools.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,12 +151,12 @@ if sys.version_info >= (3, 10):
def lru_cache(maxsize: _ProtoFunction[_P, _R], typed: bool = False) -> _FunctionDescriptor[_P, _R] | _FnHashable[_P, _R]: ...
@overload
def cache(
user_function: _ProtoMethod[_T, _P, _R]
user_function: _ProtoMethod[_T, _P, _R], /
) -> _MethodDescriptor[_T, _P, _R] | _FnHashable[Concatenate[_T, _P], _R]: ...
@overload
def cache(user_function: _ProtoClassmethod[_T, _P, _R]) -> _ClassmethodDescriptor[_T, _P, _R] | _ClsHashable[_T, _P, _R]: ...
def cache(user_function: _ProtoClassmethod[_T, _P, _R], /) -> _ClassmethodDescriptor[_T, _P, _R] | _ClsHashable[_T, _P, _R]: ...
@overload
def cache(user_function: _ProtoFunction[_P, _R]) -> _FunctionDescriptor[_P, _R] | _FnHashable[_P, _R]: ...
def cache(user_function: _ProtoFunction[_P, _R], /) -> _FunctionDescriptor[_P, _R] | _FnHashable[_P, _R]: ...

else:
@final
Expand Down