Skip to content

Fix multiple definitions for Py_fclose - #130

Merged
vstinner merged 1 commit into
python:mainfrom
cdce8p-forks:cdce8p-patch-1
Jan 26, 2025
Merged

vstinner merged 1 commit into
python:mainfrom
cdce8p-forks:cdce8p-patch-1

Conversation

@cdce8p

@cdce8p cdce8p commented Jan 26, 2025

Copy link
Copy Markdown
Contributor

While testing the lastest changes in pythoncapi_compat.h with mypy, I encountered this error

pythoncapi_compat.h:1972: multiple definition of `Py_fclose'

Believe Py_fclose is missing static inline.

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
vstinner merged commit d24c201 into python:main Jan 26, 2025
@vstinner

Copy link
Copy Markdown
Member

Oops, thanks for the fix!

@cdce8p
cdce8p deleted the cdce8p-patch-1 branch January 26, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants