Skip to content

PEP 484: Allow annotating first argument of instance and class methods #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 3 commits into from
Nov 1, 2016
Merged

PEP 484: Allow annotating first argument of instance and class methods #89

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5515644
Allow annotating first argument of instance and class methods
ilevkivskyi Sep 3, 2016
b466fa4
Response to comments
ilevkivskyi Sep 3, 2016
c5e553d
Added missing @classmethod to example
ilevkivskyi Sep 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added missing @classmethod to example
  • Loading branch information
@ilevkivskyi
ilevkivskyi committed Sep 4, 2016
commit c5e553d3b74f5a40d65761ed0a1f804012f47910
1 change: 1 addition & 0 deletions pep-0484.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1145,6 +1145,7 @@ of the first argument::

T = TypeVar('T', bound='C')
class C:
@classmethod
def factory(cls: Type[T]) -> T:

@markshannon markshannon Sep 4, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing @classmethod?

@ilevkivskyi ilevkivskyi Sep 4, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markshannon
Oops!
Thank you, fixed this.

# make a new instance of cls

Expand Down