PEP 695: Use an unquoted forward reference in the type alias example - #5153
Draft
adamtheturtle wants to merge 1 commit into
Draft
adamtheturtle wants to merge 1 commit into
adamtheturtle wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The forward-reference example quotes
Vegetableinside a|union. When the alias value is evaluated with ordinary classes,Animal | "Vegetable"raisesTypeError. Use the unquoted name and link to the existing lazy-evaluation explanation so the example also works when inspected at runtime.This clarifies the example without changing the specified semantics. For example, this succeeds on CPython 3.12 through 3.15:
Validation: the example passes on CPython 3.12.12, 3.13.13, 3.14.4, 3.14.7, and 3.15.0rc2. All pre-commit checks applicable to
peps/pep-0695.rstpass. Generated the HTML and verified the updated example and localLazy Evaluationlink. The strict Sphinx build reports warnings because all sixdocs.python.orginventories return HTTP 503, leaving existing external cross-references unresolved.PEP 123: Summary of changes)