Repository navigation
PEP 817: Wheel Variants: Beyond Platform Tags - #4740
Conversation
|
Oh thanks @hugovk I totally didn't see that one being published within 20min :D Let me know which number you want me to pick and I'll do the update ;) |
|
Thanks! @DEKHTIARJonathan You may continue with 817. |
AA-Turner
left a comment
There was a problem hiding this comment.
very brief review, I haven't yet read beyond the end of Motivation.
A
|
Just a brief bystander comment: I'm so stoked to see this PEP draft published! |
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Thanks Jannis! Took some significant amount of work but we eventually got there |
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
e34e8fa to
64f32ed
Compare
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Reflow the text to restore correct text width after all the inline changes and applied suggestions. Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Remove accidental double spaces that vim's `gq` introduced while I was reflowing the text. Thanks to @konstin for noticing. Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Co-authored-by: Ralf Gommers <ralf.gommers@gmail.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Environment marker usage and optionality is described in "Providers" section. Let's limit "Provider information" only to technical field details themselves. Signed-off-by: Michał Górny <mgorny@quansight.com>
|
I took a brief break over Christmas, aiming to look over the updates tomorrow (Saturday 3rd). A |
|
Thanks. At this point, it might be easier to look through the whole thing. I'm really looking forward to feedback whether the new version, when read top-to-bottom, makes concepts clearer without having to go back and forth, as it was necessary with the previous version. |
|
I wanted to check in with the PR, is there anything we can do for the editorial process? |
|
It seems that the copy-editing process is in pass to converge. If no blocking comment remains open by end-of-next-week (Friday 23rd January 2026), I'll ask the PEP to be merge AS-IS. I hope this gives everybody involved ample time to get in their final copy-editing reviews, before we open the DPO thread. Thanks everybody for your reviews & time ! |
|
Now the DPO thread is posted, please update the Discussions-To and Post-History headers in the PEP. |
I'll file a PR in a minute. |
* PEP 817: Wheel Variants: Beyond Platform Tags * Code-Owners editing * Apply suggestions from code review Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> * Switch to plain quotation marks Signed-off-by: Michał Górny <mgorny@quansight.com> * Move "definitions" to "specification" section Signed-off-by: Michał Górny <mgorny@quansight.com> * Reflow the cupy package list Signed-off-by: Michał Górny <mgorny@quansight.com> * Update peps/pep-0817/appendix-variant-metadata-json-schema.rst Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> * [PEP Review] JSON Schema Indent switched to 2 * Replace the benchmark chart with SVG Signed-off-by: Michał Górny <mgorny@quansight.com> * Compact the SVG Signed-off-by: Michał Górny <mgorny@quansight.com> * Reflow text Reflow the text to restore correct text width after all the inline changes and applied suggestions. Signed-off-by: Michał Górny <mgorny@quansight.com> * Replace typographic apostrophes Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove double spaces introduced while reflowing Remove accidental double spaces that vim's `gq` introduced while I was reflowing the text. Thanks to @konstin for noticing. Signed-off-by: Michał Górny <mgorny@quansight.com> * Apply suggestions from code review Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> * Remove one more "induced" Signed-off-by: Michał Górny <mgorny@quansight.com> * Apply suggestions from code review Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Carol Willing <carolcode@willingconsulting.com> * Fix list indent Signed-off-by: Michał Górny <mgorny@quansight.com> * Uppercase RFC 2119 terms Signed-off-by: Michał Górny <mgorny@quansight.com> * Replace disjunction/conjunction with OR/AND Signed-off-by: Michał Górny <mgorny@quansight.com> * Add "untrusted" to "security considerations" Signed-off-by: Michał Górny <mgorny@quansight.com> * Move "summary of changes" to the rationale Pending further rewrite. Signed-off-by: Michał Górny <mgorny@quansight.com> * Shorten "Motivation" intro, move GROMACS example to "workarounds" Signed-off-by: Michał Górny <mgorny@quansight.com> * Move reused links to "references" section To make it easier to edit sections without having to move initial definitions around. Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove unnecessary project list from "limitations of ..." These additional projects are listed without any explanation, so let's just defer to specific examples in the "current workarounds ..." section. Signed-off-by: Michał Górny <mgorny@quansight.com> * Shorten limitations of platform tags Signed-off-by: Michał Górny <mgorny@quansight.com> * Change "... limitations" to "... drawbacks" in section title Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove solution bits from "motivation" Signed-off-by: Michał Górny <mgorny@quansight.com> * Simplify update problem explanation Signed-off-by: Michał Górny <mgorny@quansight.com> * Clarify CuPy Signed-off-by: Michał Górny <mgorny@quansight.com> * Combine paragraphs on extras Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove "motivation summary" This roughly repeats the introduction to motivation, and focuses on solution rather than the problem. Signed-off-by: Michał Górny <mgorny@quansight.com> * Add SLEAP quote Signed-off-by: Michał Górny <mgorny@quansight.com> * Move "out-of-scope features" to "rejected ideas" Signed-off-by: Michał Górny <mgorny@quansight.com> * Update cupy package list, and clarify Signed-off-by: Michał Górny <mgorny@quansight.com> * Revert "Move "out-of-scope features" to "rejected ideas"" This reverts commit 261704f. Signed-off-by: Michał Górny <mgorny@quansight.com> * Move glossary and overview into Rationale Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove speccy parts from "Overview" rationale Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove "summary of changes" for now Signed-off-by: Michał Górny <mgorny@quansight.com> * Highlight the added filename part Signed-off-by: Michał Górny <mgorny@quansight.com> * Avoid forward-linking from rationale to spec Signed-off-by: Michał Górny <mgorny@quansight.com> * Expand variant properties in rationale Signed-off-by: Michał Górny <mgorny@quansight.com> * Better explain providers in "Rationale" section Signed-off-by: Michał Górny <mgorny@quansight.com> * Readd info on using providers to the spec Signed-off-by: Michał Górny <mgorny@quansight.com> * Explain metadata a bit in rationale Signed-off-by: Michał Górny <mgorny@quansight.com> * Clarify provider part of spec Signed-off-by: Michał Górny <mgorny@quansight.com> * Explain ABI variant provider in the rationale Signed-off-by: Michał Górny <mgorny@quansight.com> * Rewording of confusing bits Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove duplicate "publishes builds" verb Signed-off-by: Michał Górny <mgorny@quansight.com> * Apply suggestions from code review Co-authored-by: Ralf Gommers <ralf.gommers@gmail.com> * project tree → source tree Signed-off-by: Michał Górny <mgorny@quansight.com> * regular wheel → non-variant wheel Signed-off-by: Michał Górny <mgorny@quansight.com> * Loosen and clarify verification at install time Signed-off-by: Michał Górny <mgorny@quansight.com> * Make respecting enable-if mandatory Signed-off-by: Michał Górny <mgorny@quansight.com> * Limit recommendations to install-time providers Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove "after verifying their trustworthiness" Signed-off-by: Michał Górny <mgorny@quansight.com> * Try to clarify build-time validation Signed-off-by: Michał Górny <mgorny@quansight.com> * Update links to where security is covered now Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove duplicate/non-spec content in Providers spec Signed-off-by: Michał Górny <mgorny@quansight.com> * Move environment and pinning bits to rationale Signed-off-by: Michał Górny <mgorny@quansight.com> * Mention metadata bits in overview Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove some duplication in "Provider information" Environment marker usage and optionality is described in "Providers" section. Let's limit "Provider information" only to technical field details themselves. Signed-off-by: Michał Górny <mgorny@quansight.com> --------- Signed-off-by: Michał Górny <mgorny@quansight.com> Co-authored-by: Michał Górny <mgorny@quansight.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Carol Willing <carolcode@willingconsulting.com> Co-authored-by: Ralf Gommers <ralf.gommers@gmail.com> Co-authored-by: Barry Warsaw <barry@python.org>
Basic requirements (all PEP Types)
pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) andPEPheaderAuthororSponsor, and formally confirmed their approvalAuthor,Status(Draft),TypeandCreatedheaders filled out correctlyPEP-Delegate,Topic,RequiresandReplacesheaders completed if appropriate.github/CODEOWNERSfor the PEPStandards Track requirements
Python-Versionset to valid (pre-beta) future Python version, if relevantDiscussions-ToandPost-HistoryCC: @mgorny @konstin @rgommers @atalman @charliermarsh @msarahan @seemethere @warsaw @dstufft @aterrel
📚 Documentation preview 📚: https://pep-previews--4740.org.readthedocs.build/pep-0817/