Skip to content

PEP 601: Fix footnotes - #2736

Merged
hugovk merged 5 commits into
python:mainfrom
hugovk:pep601-fix-footnotes
Jul 28, 2022
Merged

hugovk merged 5 commits into
python:mainfrom
hugovk:pep601-fix-footnotes

Conversation

@hugovk

@hugovk hugovk commented Jul 27, 2022

Copy link
Copy Markdown
Member

Fix these warnings:

pep-0601.txt:223: WARNING: Footnote [1] is not referenced.
pep-0601.txt:225: WARNING: Footnote [2] is not referenced.
pep-0601.txt:227: WARNING: Footnote [3] is not referenced.
pep-0601.txt:229: WARNING: Footnote [4] is not referenced.
pep-0601.txt:231: WARNING: Footnote [5] is not referenced.
pep-0601.txt:233: WARNING: Footnote [6] is not referenced.
pep-0601.txt:235: WARNING: Footnote [7] is not referenced.
pep-0601.txt:237: WARNING: Footnote [8] is not referenced.
pep-0601.txt:239: WARNING: Footnote [9] is not referenced.

It was using [1] instead of [1]_.

Also:

  • Remove redundant emacs metadata
  • Fix footnote links
  • Add some inline code formatting

@hugovk hugovk added the bug label Jul 27, 2022
@hugovk
hugovk requested a review from isidentical as a code owner July 27, 2022 11:03

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, there are maybe more pressing concerns than adding literals to an old rejected PEP, but now that the work is done I don't see what not, I guess. One comment on one of the link replacements, otherwise LGTM, thanks.

Comment thread pep-0601.txt Outdated
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@hugovk
hugovk merged commit 3a79e80 into python:main Jul 28, 2022
@hugovk
hugovk deleted the pep601-fix-footnotes branch July 28, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants