Skip to content

Lint: Update headers and checks per current guidance & provide helpful feedback #2484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CAM-Gerlach merged 17 commits into from
Apr 20, 2022
Merged

Lint: Update headers and checks per current guidance & provide helpful feedback #2484

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c826909
Lint: Disable a couple potentially problematic/unneeded hooks
CAM-Gerlach Mar 29, 2022
e03b73c
Lint: Refine regex for existing Content-Type and PEP references checks
CAM-Gerlach Mar 29, 2022
8df4c4d
Lint: Refine regex for Python-Version check and fix a couple deviations
CAM-Gerlach Mar 29, 2022
2c98989
Lint: Refine regex for Created check and fix a couple deviations
CAM-Gerlach Mar 29, 2022
e75643e
Lint: Refine regex for Resolution check and fix a few deviations
CAM-Gerlach Mar 29, 2022
7abaaf3
Lint: Add new check for Post-History header
CAM-Gerlach Mar 29, 2022
ad6ba56
Lint: Add check for Discussions-To header link
CAM-Gerlach Mar 29, 2022
dd30fff
Lint: Add basic check for PEP title presense & excessive length
CAM-Gerlach Mar 29, 2022
309ec3c
Lint: Add check for PEP/BDFL-Delegate header
CAM-Gerlach Mar 30, 2022
b3fef66
Lint: Add check for Sponsor header
CAM-Gerlach Mar 30, 2022
eff7423
Lint: Add check for legacy Author field format
CAM-Gerlach Mar 30, 2022
a829dff
Lint: Add check for RST Author field
CAM-Gerlach Mar 30, 2022
90add11
Lint: Use more helpful, user-oriented descriptions for header checks
CAM-Gerlach Mar 30, 2022
3712bba
PEP 245: Add historical note and archive links to wiki page/email lsit
CAM-Gerlach Mar 31, 2022
afd0a40
PEP 628: Add direct link to resolution in acceptance message
CAM-Gerlach Mar 31, 2022
b51cde8
Lint: Explictly allow all valid RFC 2822 line continuations in headers
CAM-Gerlach Apr 1, 2022
a894d22
Lint: Tweak Post-History and Resolution checks to accept fragments
CAM-Gerlach Apr 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Lint: Disable a couple potentially problematic/unneeded hooks
  • Loading branch information
@CAM-Gerlach
CAM-Gerlach committed Apr 20, 2022
commit c8269095c8a6ff701cc36437bba588b861ec6df8
6 changes: 2 additions & 4 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ repos:
- id: mixed-line-ending
name: "Normalize mixed line endings"
args: [--fix=lf]
- id: fix-byte-order-marker
name: "Remove Unicode BOM"
- id: file-contents-sorter
name: "Sort codespell ignore list"
files: '.codespell/ignore-words.txt'
Expand All @@ -35,8 +33,8 @@ repos:
- id: check-vcs-permalinks
name: "Check that VCS links are permalinks"

- id: check-ast
name: "Check Python AST"
# - id: check-ast

@JelleZijlstra JelleZijlstra Mar 31, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed or uncommented

@CAM-Gerlach CAM-Gerlach Mar 31, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented it as a stopgap fix for #2402 , but depending on what we ultimately decide there, there's a chance we may want to restore it. That said, I can remove it, if you think its important.

# name: "Check Python AST"
- id: check-json
name: "Check JSON"
- id: check-toml
Expand Down