Repository navigation
Conversation
`dict.fromkeys([1,2])` has type `Dict[int, Any]`. The `Any` was probably intended and is exercised in this test. But this stands in the way of (maybe) making it stricter in typeshed, to be `Dict[int, None]`.
JelleZijlstra
approved these changes
Mar 2, 2020
Member
|
TBH I don't really like this idea. I think it should be Even better until PEP 585 is implemented I think mypy could use partial types to infer value type from first assignment (like it does for empty lists, dicts, etc). But this is too much work for a rare case. So |
Member
|
Just to clarify, I think the existing test should pass. |
Contributor
Author
|
OK, that's understandable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dict.fromkeys([1,2])has typeDict[int, Any]. TheAnywas probably intended and is exercised in this test. But this stands in the way of (maybe) making it stricter in typeshed, to beDict[int, None].Refs: python/typeshed#3799