Repository navigation
Re-enable promotions in isinstance checks - #6181
Merged
Michael0x2a merged 1 commit intoJan 11, 2019
Merged
Michael0x2a merged 1 commit into
Michael0x2a merged 1 commit into
Conversation
This pull request reverts python#6114 and python#6142: see python#6180 for rationale. In short, the original fix ended up being more disruptive then anticipated: it's modifying str and unicode semantics, and we should put a little more thought into reasoning about that particular case before moving ahead with any fix here. This should also help unblock the upcoming 0.660 release.
Collaborator
Author
|
I'll also reopen #6060 if we decide to go ahead with this PR. |
msullivan
approved these changes
Jan 11, 2019
msullivan
left a comment
msullivan
left a comment
Collaborator
There was a problem hiding this comment.
This issue is worth some more thought but I think this is the right course for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request reverts #6114 and #6142: see #6180 for rationale.
In short, the original fix ended up being more disruptive then anticipated: it's modifying str and unicode semantics, and we should put a little more thought into reasoning about that particular case before moving ahead with any fix here.
This should also help unblock the upcoming 0.660 release.