Skip to content

Fix checking of self when accessing a non-method callable attribute (take 2) #4016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JukkaL merged 10 commits into from
Oct 12, 2017
Merged

Fix checking of self when accessing a non-method callable attribute (take 2) #4016

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
023219b
Fix handling of non-method callable attribute (#3223)
elazarg Sep 26, 2017
dd9e609
Merge remote-tracking branch 'upstream/master' into fix-only-property…
elazarg Oct 10, 2017
295d3ff
elaborate dispatch
elazarg Oct 10, 2017
abd5426
try to elaborate docstring
elazarg Oct 10, 2017
3d941a5
move and improve error message for 0-arg attr function
elazarg Oct 10, 2017
46abe18
add and improve tests: Tuple and Meta
elazarg Oct 11, 2017
f2c6d32
demonstrate the need for meet
elazarg Oct 11, 2017
fae22af
test for non-object bound; add explicit __init__
elazarg Oct 11, 2017
a989775
add test for generic instantiation
elazarg Oct 11, 2017
eb74f85
remove commmenting of two lines
elazarg Oct 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test for non-object bound; add explicit __init__
  • Loading branch information
@elazarg
elazarg committed Oct 11, 2017
commit fae22afcba4dd1a6ce5e3a1630385f90a1279071
22 changes: 12 additions & 10 deletions test-data/unit/check-selftype.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,10 +367,11 @@ reveal_type(x.f) # E: Revealed type is 'builtins.int'

[case testSelfTypeProperSupertypeAttribute]
from typing import Callable, TypeVar
T = TypeVar('T', bound=object)
class A:
class K: pass
T = TypeVar('T', bound=K)
class A(K):
@property
def g(self: object) -> int: return 0
def g(self: K) -> int: return 0
@property
def gt(self: T) -> T: return self
f: Callable[[object], int]
Expand All @@ -392,7 +393,7 @@ reveal_type(B().ft()) # E: Revealed type is '__main__.B*'

[case testSelfTypeProperSupertypeAttributeTuple]
from typing import Callable, TypeVar, Tuple
T = TypeVar('T', bound=object)
T = TypeVar('T')
class A(Tuple[int, int]):
@property
def g(self: object) -> int: return 0
Expand All @@ -417,7 +418,7 @@ reveal_type(B().ft()) # E: Revealed type is 'Tuple[builtins.int, builtins.int,

[case testSelfTypeProperSupertypeAttributeMeta]
from typing import Callable, TypeVar, Type
T = TypeVar('T', bound=object)
T = TypeVar('T')
class A(type):
@property
def g(cls: object) -> int: return 0
Expand All @@ -429,17 +430,18 @@ class A(type):
class B(A):
pass

class X(metaclass=B): pass
class X(metaclass=B):
def __init__(self, x: int) -> None: pass
class Y(X): pass
X1: Type[X]
reveal_type(X.g) # E: Revealed type is 'builtins.int'
reveal_type(X.gt) # E: Revealed type is 'def () -> __main__.X'
reveal_type(X.gt) # E: Revealed type is 'def (x: builtins.int) -> __main__.X'
reveal_type(X.f()) # E: Revealed type is 'builtins.int'
reveal_type(X.ft()) # E: Revealed type is 'def () -> __main__.X'
reveal_type(X.ft()) # E: Revealed type is 'def (x: builtins.int) -> __main__.X'
reveal_type(Y.g) # E: Revealed type is 'builtins.int'
reveal_type(Y.gt) # E: Revealed type is 'def () -> __main__.Y'
reveal_type(Y.gt) # E: Revealed type is 'def (x: builtins.int) -> __main__.Y'
reveal_type(Y.f()) # E: Revealed type is 'builtins.int'
reveal_type(Y.ft()) # E: Revealed type is 'def () -> __main__.Y'
reveal_type(Y.ft()) # E: Revealed type is 'def (x: builtins.int) -> __main__.Y'
reveal_type(X1.g) # E: Revealed type is 'builtins.int'
reveal_type(X1.gt) # E: Revealed type is 'Type[__main__.X]'
reveal_type(X1.f()) # E: Revealed type is 'builtins.int'
Expand Down