Skip to content

Implement default values on NamedTuple #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JukkaL merged 14 commits into from
Mar 18, 2017
Merged

Implement default values on NamedTuple #2719

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
40c32d3
implement namedtuple defaults
JelleZijlstra Jan 19, 2017
def572f
fix lint
JelleZijlstra Jan 19, 2017
8ce550a
temp: attempt defaults
JelleZijlstra Jan 20, 2017
6ba17b3
make test not use index to avoid interaction with line number bug
JelleZijlstra Jan 20, 2017
df36213
add more tests, add _field_defaults
JelleZijlstra Jan 20, 2017
44f381f
remove remnants of failed attempt
JelleZijlstra Jan 20, 2017
c8715b8
test that type errors inside the default are caught
JelleZijlstra Jan 20, 2017
6ad489b
don't analyze namedtuple decorators
JelleZijlstra Jan 23, 2017
291c059
add a test for strict_optional
JelleZijlstra Jan 23, 2017
88b63fb
don't use cast in test
JelleZijlstra Jan 24, 2017
1fe9792
fewer checks for is_namedtuple
JelleZijlstra Jan 24, 2017
51c3dc4
Merge branch 'master' into namedtupledefault
gvanrossum Mar 13, 2017
91acfc7
Merge branch 'master' into namedtupledefault
JelleZijlstra Mar 18, 2017
3df509a
add a few more tests
JelleZijlstra Mar 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
don't analyze namedtuple decorators 
Would be nice to support this but that's for a separate issue.
  • Loading branch information
@JelleZijlstra
JelleZijlstra committed Jan 23, 2017
commit 6ad489be6cb5feccf7046b226f71f1474be8783d
4 changes: 2 additions & 2 deletions mypy/semanal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,8 +574,8 @@ def visit_class_def(self, defn: ClassDef) -> None:
self.analyze_base_classes(defn)
self.analyze_metaclass(defn)

for decorator in defn.decorators:
self.analyze_class_decorator(defn, decorator)
for decorator in defn.decorators:
self.analyze_class_decorator(defn, decorator)

self.enter_class(defn)

Expand Down