Skip to content

Handle arg=<sentinel value> in stubgen #22019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 9 commits into from
Oct 7, 2026
+114 −0
Merged

Handle arg=<sentinel value> in stubgen #22019

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
662e889
Handle arg=<sentinel value> in stubgenc
edgarrmondragon Sep 21, 2026
07cb6bd
Add cases to stubgen.test
edgarrmondragon Sep 22, 2026
3eebd9b
Annotate with sentinel type in generated stub
edgarrmondragon Sep 23, 2026
892c03d
Re-declare sentinel in stub
edgarrmondragon Sep 25, 2026
49d5ce8
Add sentinel to the stub annotation whenever is has a valid `__name__`
edgarrmondragon Sep 25, 2026
786dc62
Trim down comment
edgarrmondragon Sep 25, 2026
d87772b
Remove redundant test
edgarrmondragon Sep 25, 2026
59e72eb
Refactor
edgarrmondragon Sep 25, 2026
04184f0
Merge branch 'master' into stubgen-sentinel
edgarrmondragon Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor 
Signed-off-by: Edgar Ramírez-Mondragón <edgarrm358@gmail.com>
  • Loading branch information
@edgarrmondragon
edgarrmondragon committed Sep 25, 2026
commit 59e72ebe84ce565b06c8769502d4b172f0521454
13 changes: 6 additions & 7 deletions mypy/stubgenc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,15 +332,14 @@ def add_args(
if default_value is not _Missing.VALUE:
if arg in annotations:
argtype = get_annotation(arg)
elif _is_sentinel_object(default_value):
# Reference the sentinel itself by name when possible, e.g.
# `Incomplete | _MISSING`.
incomplete = self.add_name("_typeshed.Incomplete")
ref = self._sentinel_type_ref(default_value)
argtype = f"{incomplete} | {ref}" if ref else incomplete
else:
argtype = self.get_type_annotation(default_value)
if _is_sentinel_object(default_value):
# Reference the sentinel itself by name when possible, e.g.
# `Incomplete | _MISSING`.
incomplete = self.add_name("_typeshed.Incomplete")
ref = self._sentinel_type_ref(default_value)
argtype = f"{incomplete} | {ref}" if ref else incomplete

if argtype == "None":
# None is not a useful annotation, but we can infer that the arg
# is optional
Expand Down
Loading