Skip to content

Fix module and protocol subtyping, module hasattr #13778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 3 commits into from
Oct 2, 2022
Merged

Fix module and protocol subtyping, module hasattr #13778

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b37c479
Fix module and protocol subtyping
hauntsaninja Sep 30, 2022
4d38174
fix module hasattr
hauntsaninja Sep 30, 2022
1a1f3a1
random tests
hauntsaninja Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix module and protocol subtyping
  • Loading branch information
@hauntsaninja
hauntsaninja committed Sep 30, 2022
commit b37c47955588d46fe94f10c0bdc1801317656b30
1 change: 1 addition & 0 deletions mypy/subtypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,6 +1078,7 @@ def find_member(
and name not in ["__getattr__", "__setattr__", "__getattribute__"]
and not is_operator
and not class_obj
and itype.extra_attrs is None # skip ModuleType.__getattr__
):
for method_name in ("__getattribute__", "__getattr__"):
# Normally, mypy assumes that instances that define __getattr__ have all
Expand Down
5 changes: 3 additions & 2 deletions test-data/unit/lib-stub/types.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
from typing import TypeVar
from typing import Any, TypeVar
import sys

_T = TypeVar('_T')

def coroutine(func: _T) -> _T: pass

class ModuleType:
__file__ = ... # type: str
__file__: str
def __getattr__(self, name: str) -> Any: pass

if sys.version_info >= (3, 10):
class Union:
Expand Down