Skip to content

Enable generic NamedTuples #13396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 7 commits into from
Aug 15, 2022
Merged

Enable generic NamedTuples #13396

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
550423e
Enable definition of generic tuple types
ilevkivskyi Aug 12, 2022
83f7808
Add support for mapping to supertype
ilevkivskyi Aug 12, 2022
417fc57
Better logic for recursive generic named tuples
ilevkivskyi Aug 12, 2022
12c4f02
More tests for regular classes
ilevkivskyi Aug 12, 2022
41fab83
Add generic alias test
ilevkivskyi Aug 13, 2022
98a637d
Add incremental tests
ilevkivskyi Aug 13, 2022
7905afb
Add support for call syntax
ilevkivskyi Aug 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More tests for regular classes
  • Loading branch information
@ilevkivskyi
ilevkivskyi committed Aug 12, 2022
commit 12c4f02a7dde676c7d9a64c932fd9c5f749b850a
19 changes: 18 additions & 1 deletion test-data/unit/check-classes.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7333,9 +7333,26 @@ d: bool = child.foobar()
[case testGenericTupleTypeCreation]
from typing import Generic, Tuple, TypeVar

T = TypeVar("T")
S = TypeVar("S")
class C(Tuple[T, S]):
def __init__(self, x: T, y: S) -> None: ...
def foo(self, arg: T) -> S: ...

cis: C[int, str]
reveal_type(cis) # N: Revealed type is "Tuple[builtins.int, builtins.str, fallback=__main__.C[builtins.int, builtins.str]]"
cii = C(0, 1)
reveal_type(cii) # N: Revealed type is "Tuple[builtins.int, builtins.int, fallback=__main__.C[builtins.int, builtins.int]]"
reveal_type(cis.foo) # N: Revealed type is "def (arg: builtins.int) -> builtins.str"
[builtins fixtures/tuple.pyi]

[case testGenericTupleTypeSubclassing]
from typing import Generic, Tuple, TypeVar
from typing import Generic, Tuple, TypeVar, List

T = TypeVar("T")
class C(Tuple[T, T]): ...
class D(C[List[T]]): ...

di: D[int]
reveal_type(di) # N: Revealed type is "Tuple[builtins.list[builtins.int], builtins.list[builtins.int], fallback=__main__.D[builtins.int]]"
[builtins fixtures/tuple.pyi]