Skip to content

Add unbound typevar check #13166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 23 commits into from
Jul 19, 2022
Merged

Add unbound typevar check #13166

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
cc8d33f
Add simple unbound typevar check and rudimentary test
Jul 17, 2022
cc8faff
Add test for unbound func returning iterables of TypeVars
Jul 17, 2022
a771393
Add appropriate error message and make the new test pass
Jul 17, 2022
714445e
add CollectArgTypes to get set of argument types
anilbey Jul 17, 2022
595ec8c
Merge branch 'add-unbound-typevar-check' of github.com:AurelienJaquie…
anilbey Jul 17, 2022
db501a9
lint fix
anilbey Jul 17, 2022
e31f967
fix type error
anilbey Jul 17, 2022
951a54d
extract check_unbound_return_typevar as method
anilbey Jul 17, 2022
b9b1561
check if return type is instantiated in typ.variables
anilbey Jul 17, 2022
0335cc1
Fix some tests that are affected by new implementation
Jul 17, 2022
0cf8e93
Merge branch 'add-unbound-typevar-check' of https://github.com/Aureli…
Jul 17, 2022
1ddf301
add testInnerFunctionTypeVar test
anilbey Jul 17, 2022
32c0c84
fix testErrorCodeNeedTypeAnnotation test
Jul 17, 2022
1175d53
add TYPE_VAR error code to unbound error failure
anilbey Jul 17, 2022
f1a27d1
Merge branch 'add-unbound-typevar-check' of https://github.com/Aureli…
Jul 17, 2022
402a4e3
Fix the tests
Jul 17, 2022
34dc475
move new tests in new test file
Jul 17, 2022
b78b926
add 'check-typevar-unbound.test' to testcheck
anilbey Jul 18, 2022
ce9ceaf
add more nested tests for unbound type
anilbey Jul 18, 2022
64b1834
microoptimise check_unbound_return_typevar check ret_type first
anilbey Jul 18, 2022
0ff4b12
Merge branch 'master' into add-unbound-typevar-check
ilevkivskyi Jul 18, 2022
4352bc3
add missing builtins fixture to failing test
anilbey Jul 18, 2022
abb6f1c
Merge branch 'add-unbound-typevar-check' of github.com:AurelienJaquie…
anilbey Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into add-unbound-typevar-check
  • Loading branch information
@ilevkivskyi
ilevkivskyi authored Jul 18, 2022
commit 0ff4b120ed451cd112ed4b41e71a7ee5d573a0f7
81 changes: 2 additions & 79 deletions mypy/test/testcheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,85 +30,8 @@
import pytest

# List of files that contain test case descriptions.
typecheck_files = [
'check-basic.test',
'check-union-or-syntax.test',
'check-callable.test',
'check-classes.test',
'check-statements.test',
'check-generics.test',
'check-dynamic-typing.test',
'check-inference.test',
'check-inference-context.test',
'check-kwargs.test',
'check-overloading.test',
'check-type-checks.test',
'check-abstract.test',
'check-multiple-inheritance.test',
'check-super.test',
'check-modules.test',
'check-modules-fast.test',
'check-typevar-values.test',
'check-unsupported.test',
'check-unreachable-code.test',
'check-unions.test',
'check-isinstance.test',
'check-lists.test',
'check-namedtuple.test',
'check-narrowing.test',
'check-typeddict.test',
'check-type-aliases.test',
'check-ignore.test',
'check-type-promotion.test',
'check-semanal-error.test',
'check-flags.test',
'check-incremental.test',
'check-serialize.test',
'check-bound.test',
'check-optional.test',
'check-fastparse.test',
'check-warnings.test',
'check-async-await.test',
'check-newtype.test',
'check-class-namedtuple.test',
'check-selftype.test',
'check-python2.test',
'check-columns.test',
'check-functions.test',
'check-tuples.test',
'check-expressions.test',
'check-generic-subtyping.test',
'check-varargs.test',
'check-newsyntax.test',
'check-protocols.test',
'check-underscores.test',
'check-classvar.test',
'check-enum.test',
'check-incomplete-fixture.test',
'check-custom-plugin.test',
'check-default-plugin.test',
'check-attr.test',
'check-ctypes.test',
'check-dataclasses.test',
'check-final.test',
'check-redefine.test',
'check-literal.test',
'check-newsemanal.test',
'check-inline-config.test',
'check-reports.test',
'check-errorcodes.test',
'check-annotated.test',
'check-parameter-specification.test',
'check-typevar-tuple.test',
'check-typevar-unbound.test',
'check-generic-alias.test',
'check-typeguard.test',
'check-functools.test',
'check-singledispatch.test',
'check-slots.test',
'check-formatting.test',
'check-native-int.test',
]
# Includes all check-* files with the .test extension in the test-data/unit directory
typecheck_files = find_test_files(pattern="check-*.test")

# Tests that use Python 3.8-only AST features (like expression-scoped ignores):
if sys.version_info < (3, 8):
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.