Skip to content

Adds support for NamedTuple subtyping #11162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JukkaL merged 6 commits into from
Nov 5, 2021
Merged

Adds support for NamedTuple subtyping #11162

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7afe130
Adds support for `NamedTuple` subtyping, refs #11160
sobolevn Sep 21, 2021
c0976b4
Adds `._source` attribute to `NamedTuple` type
sobolevn Sep 22, 2021
5fb7a88
Adds more tests and docs
sobolevn Sep 24, 2021
11bd1ae
Fixes tests output location
sobolevn Sep 24, 2021
8c20b7c
Improves tests and docs
sobolevn Nov 4, 2021
137c28b
Fixes tests, add `Mapping` to new fixture
sobolevn Nov 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes tests output location
  • Loading branch information
@sobolevn
sobolevn committed Sep 24, 2021
commit 11bd1aee48804d620ffac21c43b6359b7fd98838
16 changes: 11 additions & 5 deletions test-data/unit/pythoneval.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1398,17 +1398,23 @@ A = NamedTuple('A', [('param', int)])
B = namedtuple('B', ['param'])

def accepts_named_tuple(arg: NamedTuple):
reveal_type(arg._asdict()) # N: Revealed type is "builtins.dict[builtins.str, Any]"
reveal_type(arg._fields) # N: Revealed type is "builtins.tuple[builtins.str]"
reveal_type(arg._field_defaults) # N: Revealed type is "builtins.dict[builtins.str, Any]"
reveal_type(arg._asdict())
reveal_type(arg._fields)
reveal_type(arg._field_defaults)

a = A(1)
b = B(1)

accepts_named_tuple(a)
accepts_named_tuple(b)
accepts_named_tuple(1) # E: Argument 1 to "accepts_named_tuple" has incompatible type "int"; expected "NamedTuple"
accepts_named_tuple((1, 2)) # E: Argument 1 to "accepts_named_tuple" has incompatible type "Tuple[int, int]"; expected "NamedTuple"
accepts_named_tuple(1)
accepts_named_tuple((1, 2))
[out]
_testNamedTupleTypeInheritanceSpecialCase.py:8: note: Revealed type is "collections.OrderedDict[builtins.str, Any]"
_testNamedTupleTypeInheritanceSpecialCase.py:9: note: Revealed type is "builtins.tuple[builtins.str]"
_testNamedTupleTypeInheritanceSpecialCase.py:10: note: Revealed type is "builtins.dict[builtins.str, Any]"
_testNamedTupleTypeInheritanceSpecialCase.py:17: error: Argument 1 to "accepts_named_tuple" has incompatible type "int"; expected "NamedTuple"
_testNamedTupleTypeInheritanceSpecialCase.py:18: error: Argument 1 to "accepts_named_tuple" has incompatible type "Tuple[int, int]"; expected "NamedTuple"

[case testNewAnalyzerBasicTypeshed_newsemanal]
from typing import Dict, List, Tuple
Expand Down