Skip to content

[dataclasses plugin] Support kw_only=True #10867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 7 commits into from
Aug 8, 2021
Merged

[dataclasses plugin] Support kw_only=True #10867

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
09fd718
[dataclasses plugin] Support kw_only=True
tgallant Jul 24, 2021
44f80e0
adds subclassing test case
tgallant Aug 2, 2021
56b7441
ensure dataclass init fn has the correct signature
tgallant Aug 2, 2021
97fdc59
ensure that the KW_ONLY sentinel is only provided once
tgallant Aug 2, 2021
0b40504
adds initialization to dataclass tests
tgallant Aug 2, 2021
32384e1
updates KW_ONLY sentinel usage in test stubs
tgallant Aug 5, 2021
2a2cd69
adds dataclass argument type test cases
tgallant Aug 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adds initialization to dataclass tests
  • Loading branch information
@tgallant
tgallant committed Aug 7, 2021
commit 0b405048a1f07bae9bff71fc69c6cef83367f5e6
6 changes: 6 additions & 0 deletions test-data/unit/check-dataclasses.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,8 @@ class Application:
name: str = 'Unnamed'
rating: int

Application(rating=5)

[builtins fixtures/list.pyi]

[case testDataclassesOrderingKwOnlyOnField]
Expand All @@ -331,6 +333,8 @@ class Application:
name: str = 'Unnamed'
rating: int = field(kw_only=True)

Application(rating=5)

[builtins fixtures/list.pyi]

[case testDataclassesOrderingKwOnlyOnFieldFalse]
Expand All @@ -354,6 +358,8 @@ class Application:
name: str = 'Unnamed'
rating: int

Application(rating=5)

[builtins fixtures/list.pyi]

[case testDataclassesOrderingKwOnlyWithSentinelAndFieldOverride]
Expand Down