Skip to content

Honor '/'-separated names in ResourceContainer.joinpath. - #249

Merged
jaraco merged 2 commits into
mainfrom
bugfix/resource-container-pathsep
Apr 17, 2022
Merged

jaraco merged 2 commits into
mainfrom
bugfix/resource-container-pathsep

Conversation

@jaraco

@jaraco jaraco commented Apr 14, 2022

Copy link
Copy Markdown
Member

No description provided.

@FFY00

FFY00 commented Apr 14, 2022 •

Copy link
Copy Markdown
Member

I know this was initially mentioned in #248 (comment) but I can't seem to find where that promise is made. Would you be able to point it out to me?

IMO adding this to the interface isn't great, but if a promise exists already, this is indeed a correct fix.

@jaraco

jaraco commented Apr 14, 2022

Copy link
Copy Markdown
Member Author

See python/cpython#91298 and the latest docstring for Traversable.joinpath.

@jaraco
jaraco merged commit 8dceab3 into main Apr 17, 2022
@jaraco
jaraco deleted the bugfix/resource-container-pathsep branch April 17, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants