Skip to content

Remove compatibility shims for entry points. #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaraco merged 8 commits into from
Oct 2, 2022
Merged

Remove compatibility shims for entry points. #405

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7e5bae4
Remove SelectableGroups
jaraco Oct 1, 2022
47544ce
Remove DeprecatedList
jaraco Oct 1, 2022
0c81964
Remove compatibility for EntryPoints.__getitem__ by index.
jaraco Oct 1, 2022
dde2b9d
Remove support for cast of iterable of entry points to dict. Ref #97.
jaraco Oct 1, 2022
6ed01ae
Merge removal commits into feature/clean-entry-points
jaraco Oct 1, 2022
2135490
Update changelog
jaraco Oct 1, 2022
117d1b4
Disable flake8 due to incompatibility.
jaraco Oct 1, 2022
ac9ff95
Update documentation around removal of SelectableGroups.
jaraco Oct 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove DeprecatedList
  • Loading branch information
@jaraco
jaraco committed Oct 1, 2022
commit 47544ce7303da9b2147c6603a674a1f82225248f
95 changes: 1 addition & 94 deletions importlib_metadata/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,100 +209,7 @@ def matches(self, **params):
return all(map(operator.eq, params.values(), attrs))


class DeprecatedList(list):
"""
Allow an otherwise immutable object to implement mutability
for compatibility.

>>> recwarn = getfixture('recwarn')
>>> dl = DeprecatedList(range(3))
>>> dl[0] = 1
>>> dl.append(3)
>>> del dl[3]
>>> dl.reverse()
>>> dl.sort()
>>> dl.extend([4])
>>> dl.pop(-1)
4
>>> dl.remove(1)
>>> dl += [5]
>>> dl + [6]
[1, 2, 5, 6]
>>> dl + (6,)
[1, 2, 5, 6]
>>> dl.insert(0, 0)
>>> dl
[0, 1, 2, 5]
>>> dl == [0, 1, 2, 5]
True
>>> dl == (0, 1, 2, 5)
True
>>> len(recwarn)
1
"""

_warn = functools.partial(
warnings.warn,
"EntryPoints list interface is deprecated. Cast to list if needed.",
DeprecationWarning,
stacklevel=2,
)

def __setitem__(self, *args, **kwargs):
self._warn()
return super().__setitem__(*args, **kwargs)

def __delitem__(self, *args, **kwargs):
self._warn()
return super().__delitem__(*args, **kwargs)

def append(self, *args, **kwargs):
self._warn()
return super().append(*args, **kwargs)

def reverse(self, *args, **kwargs):
self._warn()
return super().reverse(*args, **kwargs)

def extend(self, *args, **kwargs):
self._warn()
return super().extend(*args, **kwargs)

def pop(self, *args, **kwargs):
self._warn()
return super().pop(*args, **kwargs)

def remove(self, *args, **kwargs):
self._warn()
return super().remove(*args, **kwargs)

def __iadd__(self, *args, **kwargs):
self._warn()
return super().__iadd__(*args, **kwargs)

def __add__(self, other):
if not isinstance(other, tuple):
self._warn()
other = tuple(other)
return self.__class__(tuple(self) + other)

def insert(self, *args, **kwargs):
self._warn()
return super().insert(*args, **kwargs)

def sort(self, *args, **kwargs):
self._warn()
return super().sort(*args, **kwargs)

def __eq__(self, other):
if not isinstance(other, tuple):
self._warn()
other = tuple(other)

return tuple(self).__eq__(other)


class EntryPoints(DeprecatedList):
class EntryPoints(tuple):
"""
An immutable collection of selectable EntryPoint objects.
"""
Expand Down