Skip to content

Add compatibility for PathDistributions implemented with stdlib objects in Python 3.8/3.9 #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaraco merged 15 commits into from
Oct 1, 2022
Merged

Add compatibility for PathDistributions implemented with stdlib objects in Python 3.8/3.9 #397

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9c2e16e
Capture expectations about _normalized_name compatibility in test
abravalheri Jul 18, 2022
eb621bd
Add compatibility layer for Python 3.8 stdlib lack of _normalized_name
abravalheri Jul 15, 2022
56b071f
Add compatibility for EntryPoint.matches in stdlib 3.8/3.9
abravalheri Jul 18, 2022
dff9d32
Add type annotations to EntryPoint.name/value/group
abravalheri Jul 18, 2022
718cdef
Make sure Python 3.8/3.9 compatibility tests run on CI
abravalheri Jul 18, 2022
65d65e1
Workaround missing distribution name
abravalheri Jul 18, 2022
ab40e39
Fix typecheck error by simplifying compatibility shim
abravalheri Jul 18, 2022
9333ab5
Add "short circuit" optimization
abravalheri Jul 18, 2022
a156b85
Extract tests for Python 3.9 compatibility into their own file
abravalheri Aug 31, 2022
0bda2fe
Extract Python 3.9 compatibility layer into its own file
abravalheri Aug 31, 2022
05cb079
Add comments clarifying implementation choices
abravalheri Aug 31, 2022
1e32edd
Fix imports
abravalheri Aug 31, 2022
17cc30e
Skip coverage in type checking statement
abravalheri Aug 31, 2022
f17f1b3
Merge branch 'main' into issue-396
jaraco Oct 1, 2022
25998e4
Update changelog
jaraco Oct 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip coverage in type checking statement
  • Loading branch information
@abravalheri
abravalheri committed Aug 31, 2022
commit 17cc30eccfc889b361611d990eba43b4c9a6db06
3 changes: 2 additions & 1 deletion importlib_metadata/_py39compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"""
from typing import TYPE_CHECKING, Any, Optional, Tuple

if TYPE_CHECKING: # -> prevent circular imports on runtime.
if TYPE_CHECKING: # pragma: no cover
# Prevent circular imports on runtime.
from . import Distribution, EntryPoint
else:
Distribution = EntryPoint = Any
Expand Down