Skip to content

Validate name arg in Distribution.from_name #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaraco merged 4 commits into from
Jun 25, 2022
Merged

Validate name arg in Distribution.from_name #391

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4ae953
Add xfail test capturing new expectation.
jaraco Jun 23, 2022
eb19c64
In Distribution.from_name, require a non-empty string. Fixes python/c…
jaraco Jun 25, 2022
c96dc1e
Merge branch 'main' into ghpython-93259/from-name-arg-validation-simple
jaraco Jun 25, 2022
91b7149
Update changelog
jaraco Jun 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into ghpython-93259/from-name-arg-validation-simple
  • Loading branch information
@jaraco
jaraco authored Jun 25, 2022
commit c96dc1e77f032315bfc78f0c1d13c9a61fb68c3f
9 changes: 3 additions & 6 deletions importlib_metadata/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,12 +560,9 @@ def from_name(cls, name: str):
"""
if not name:
raise ValueError("A distribution name is required.")
for resolver in cls._discover_resolvers():
dists = resolver(DistributionFinder.Context(name=name))
dist = next(iter(dists), None)
if dist is not None:
return dist
else:
try:
return next(cls.discover(name=name))
except StopIteration:
raise PackageNotFoundError(name)

@classmethod
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.