Skip to content

Complete type annotations #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andersk wants to merge 14 commits into from
Closed

Complete type annotations #342

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
67909a0
Linearize base classes of SelectableGroups
andersk Aug 25, 2021
70f1f24
DeprecatedList: Only warn when comparing to other lists
andersk Aug 25, 2021
cb0acdf
EntryPoints: Improve __getitem__ compatibility
andersk Aug 25, 2021
0e960d4
SimplePath: Add .read_text(encoding) and .read_bytes()
andersk Aug 25, 2021
53e1a53
FoldedCase: Improve split() compatibility
andersk Aug 26, 2021
1790ef2
tests: Correct self.skip to self.skipTest
andersk Aug 26, 2021
3e474b2
FoldedCase: Improve index() compatibility
andersk Aug 26, 2021
f21fe55
FoldedCase: Accept arbitrary objects in __eq__, __ne__, __contains__
andersk Aug 26, 2021
bb603e5
Replace always_iterable with ‘or []’
andersk Aug 26, 2021
f803c93
entry_points: Remove unnecessary functools.partial
andersk Aug 26, 2021
6e3903e
EntryPoint: Remove None default for dist
andersk Aug 26, 2021
fb0adc7
tests: Replace __init__ with setUp.
andersk Aug 26, 2021
b1b358b
Complete type annotations
andersk Aug 26, 2021
324fd33
mypy: Enable strict mode
andersk Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
FoldedCase: Improve split() compatibility 
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
  • Loading branch information
@andersk
andersk committed Aug 26, 2021
commit 53e1a5354fb6590f2f1b8db6d9b5fc0cd8fdbcc3
7 changes: 6 additions & 1 deletion importlib_metadata/_text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ class FoldedCase(str):
>>> s.split('O')
['hell', ' w', 'rld']

>>> s.split()
['hello', 'world']

>>> sorted(map(FoldedCase, ['GAMMA', 'alpha', 'Beta']))
['alpha', 'Beta', 'GAMMA']

Expand Down Expand Up @@ -94,6 +97,8 @@ def lower(self):
def index(self, sub):
return self.lower().index(sub.lower())

def split(self, splitter=' ', maxsplit=0):
def split(self, splitter=None, maxsplit=0):
if splitter is None:

@jaraco jaraco Aug 26, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change may deserve its own issue. Since it's changing the interface, it may even require a deprecation. It may be sufficient to simply provide more test coverage of this behavior.

@andersk andersk Aug 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is in its own commit that adds test coverage. I assumed the goal was compatibility with str, but if you’d prefer to keep strict backwards compatibility with old versions of FoldedCase, we could leave splitter=' ' as the default?

return super().split()
pattern = re.compile(re.escape(splitter), re.I)
return pattern.split(self, maxsplit)