Skip to content

Use a config file. #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JulienPalard merged 20 commits into from
Oct 17, 2023
Merged

Use a config file. #143

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
3497b2b
Drop unused version.sphinxopts
JulienPalard Jan 6, 2023
2b53a17
Use a config file for easier discoverability.
JulienPalard Jan 6, 2023
850e5a3
Use branch info from the devguide.
JulienPalard Oct 12, 2023
6fc683c
Move latex config to config file.
JulienPalard Oct 12, 2023
de24eb7
Proofreading.
JulienPalard Oct 12, 2023
d3e86f6
Clone indiferently branches and tags.
JulienPalard Oct 12, 2023
aeb773d
Those arguments can't contain newlines.
JulienPalard Oct 12, 2023
7cc0aa4
Has been removed in d5a0a72b373c81f64bbabcbe8b885ba2a409be38.
JulienPalard Oct 12, 2023
2b2af6d
Can't clone with to an unexisting directory.
JulienPalard Oct 14, 2023
6c8d0b4
Fix link.
JulienPalard Oct 14, 2023
8389b9e
More uses of the Git class, thanks to AA-Turner review.
JulienPalard Oct 14, 2023
88becd0
Purge helper.
JulienPalard Oct 14, 2023
b81466f
Avoid some lookups.
JulienPalard Oct 14, 2023
2a9e24f
Not usefull.
JulienPalard Oct 14, 2023
d515559
tag can be deduced from iso-tag.
JulienPalard Oct 14, 2023
d83b830
Maybe better names for repository and remote.
JulienPalard Oct 14, 2023
6ed6b92
Run a single git fetch on cpython.
JulienPalard Oct 14, 2023
98fec40
It's 2023!
JulienPalard Oct 15, 2023
ca34047
For the main branch, show-ref also finds the heads/main.
JulienPalard Oct 16, 2023
5a4c953
--language semantic has not been changed.
JulienPalard Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Maybe better names for repository and remote.
  • Loading branch information
@JulienPalard
JulienPalard committed Oct 14, 2023
commit d83b8302b9d8c8c9d6b13c3d1e7f46ff7f33353c
16 changes: 8 additions & 8 deletions build_docs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,10 +273,10 @@ def traverse(dircmp_result):


@dataclass
class Git:
"""Git command abstraction for our specific needs."""
class Repository:
"""Git repository abstraction for our specific needs."""

repository: str
remote: str
directory: Path

def run(self, *args):
Expand All @@ -297,9 +297,9 @@ def clone(self):
"""Maybe clone the repository, if not already cloned."""
if (self.directory / ".git").is_dir():
return # Already cloned
logging.info("Cloning %s into %s", self.repository, self.directory)
logging.info("Cloning %s into %s", self.remote, self.directory)
self.directory.mkdir(mode=0o775, parents=True, exist_ok=True)
run(["git", "clone", self.repository, self.directory])
run(["git", "clone", self.remote, self.directory])


def version_to_tuple(version):
Expand Down Expand Up @@ -344,7 +344,7 @@ def locate_nearest_version(available_versions, target_version):
return tuple_to_version(found)


def translation_branch(repo: Git, needed_version: str):
def translation_branch(repo: Repository, needed_version: str):
"""Some cpython versions may be untranslated, being either too old or
too new.

Expand Down Expand Up @@ -678,12 +678,12 @@ def clone_translation(self):
/ self.language.iso639_tag
/ "LC_MESSAGES"
)
repo = Git(locale_repo, locale_clone_dir)
repo = Repository(locale_repo, locale_clone_dir)
repo.clone()
repo.switch(translation_branch(repo, self.version.name))

def clone_cpython(self):
repo = Git("https://github.com/python/cpython.git", self.checkout)
repo = Repository("https://github.com/python/cpython.git", self.checkout)
repo.clone()
repo.switch(self.version.branch_or_tag)

Expand Down