Skip to content

Add a note about not modifying the git history to the quick guide #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aeros merged 4 commits into from
May 24, 2020
Merged

Add a note about not modifying the git history to the quick guide #588

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b47ba10
Add a note about not modifying the git history to the quick guide
DahlitzFlorian May 21, 2020
44820d7
Apply code review suggestions from @aeros
DahlitzFlorian May 21, 2020
3d539c6
Apply changes as suggested by @terryjreedy
DahlitzFlorian May 22, 2020
027b79b
Apply suggestions proposed by @willingc
DahlitzFlorian May 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pullrequest.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Here is a quick overview of how you can contribute to CPython:

#. `Create Pull Request`_ on GitHub to merge a branch from your fork

#. Review and address `comments on your Pull Request`_
#. Review and address `comments on your Pull Request`_ (without force-pushing)
Comment thread
DahlitzFlorian marked this conversation as resolved.
Outdated

#. When your changes are merged, you can :ref:`delete the PR branch
<deleting_branches>`
Expand All @@ -47,6 +47,10 @@ Here is a quick overview of how you can contribute to CPython:
.. [*] If an issue is trivial (e.g. typo fixes), or if an issue already exists,
you can skip this step.

.. note::
Please keep the commit history in the pull request intact by not squashing,
amending, or anything that would require a force push to GitHub.

Comment thread
DahlitzFlorian marked this conversation as resolved.
.. _Clear communication: https://opensource.guide/how-to-contribute/#how-to-submit-a-contribution
.. _Open Source: https://opensource.guide/
.. _create an issue: https://bugs.python.org/
Expand Down