Skip to content

Fix good commit example to use imperative title #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aeros merged 5 commits into from
May 25, 2020
Merged

Fix good commit example to use imperative title #587

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b5876f
Merge remote-tracking branch 'upstream/master'
DahlitzFlorian May 21, 2020
e6432e1
Fix good commit example to use imperative title
DahlitzFlorian May 21, 2020
a2a902e
Apply suggestions from code review @aeros
DahlitzFlorian May 22, 2020
7d16a28
Apply suggestion made by @terryjreedy
DahlitzFlorian May 24, 2020
2be1ce9
Apply changes suggested by @aeros
DahlitzFlorian May 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply changes suggested by @aeros 
Co-authored-by: Kyle Stanley <aeros167@gmail.com>
  • Loading branch information
@DahlitzFlorian @aeros
DahlitzFlorian and aeros authored May 25, 2020
commit 2be1ce902d1f5e9cbca5d518764e40af4f6e48dc
2 changes: 1 addition & 1 deletion pullrequest.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ request.

.. note::
`How to Write a Git Commit Message <https://chris.beams.io/posts/git-commit/>`_
is a nice article describing how to write a good commit message.
is a nice article that describes how to write a good commit message.


.. _cla:
Expand Down