Skip to content

Update the quick start. - #115

Merged
willingc merged 2 commits into
python:masterfrom
ezio-melotti:new-quickstart
Feb 15, 2017
Merged

willingc merged 2 commits into
python:masterfrom
ezio-melotti:new-quickstart

Conversation

@ezio-melotti

@ezio-melotti ezio-melotti commented Feb 15, 2017 •

Copy link
Copy Markdown
Member

I updated the quick start, trying to making it more compact and clarifying a few points (e.g. users should clone the repo from their own account, not from python/cpython).

Comment thread index.rst Outdated
(see the :ref:`Get Setup <setup>` page for detailed information).

Install :ref:`Git <vcsetup>` and other dependencies.
2. Fork `the CPython repository on GitHub <cpython github>`_ and

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...GitHub to your GitHub account and...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be clear enough, since immediately after it clones from the user account.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezio-melotti For someone that has used git, your wording is fine. If someone new to git/GitHub is trying to help, they will often get confused about what is getting forked and cloned where. I know it seems trivial, but it really does help those who are still learning.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2. Fork `the CPython repository <cpython github>`_ to your GitHub account
   and :ref:`get the source code <checkout>` using::

      git clone https://github.com/<your_username>/cpython

Is this clear enough?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @ezio-melotti

Comment thread index.rst Outdated
5. Work on an issue from the `issue tracker`_. If an issue does not already
exist, please create it. Trivial issues, like small typo fixes, do not
require any issue to be created.
5. Create a new branch where to work on an issue with::

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5. Create new branch where your work for the issue will go:

     git checkout -b new_branch_name master

For example, use `git checkout -b fix_issue master` to create a new branch named `fix_issue`.

...create it on the ...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5. Create a new branch where your work for the issue will go, e.g.::

     git checkout -b fix-issue-12345 master

Is this OK?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like this change 👍

Comment thread index.rst Outdated
6. Make a :doc:`pull request <pullrequest>`.
Include ``bpo-NNNN`` in the pull request description, where ``NNNN`` is the
issue number from the `issue tracker`_. For example::
7. Push the branch on your fork and :doc:`create a pull request <pullrequest>`.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...your fork on GitHub and...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@willingc willingc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ezio-melotti. A few small clarifications for new contributors.

@willingc
willingc merged commit f62563c into python:master Feb 15, 2017
@willingc

Copy link
Copy Markdown
Collaborator

Thank you @ezio-melotti 🍪

@Mariatta

Copy link
Copy Markdown
Member

This looks great! Thank you @ezio-melotti 🎉

@ezio-melotti
ezio-melotti deleted the new-quickstart branch February 15, 2017 05:44
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Jun 17, 2022
* Update the quick start.

* Address review comments and fix two external links.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants