Skip to content

gh-81057: Move More Globals in Core Code to _PyRuntimeState #99516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 18 commits into from
Nov 16, 2022
Merged

gh-81057: Move More Globals in Core Code to _PyRuntimeState #99516

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
caec551
Drop outdated whitelist entries.
ericsnowcurrently Nov 15, 2022
f6b90ee
Move make_pending_calls():busy to _PyRuntimeState.
ericsnowcurrently Nov 15, 2022
a6be5a3
Move urandom_cache to _PyRuntimeState.
ericsnowcurrently Nov 15, 2022
fb33ede
Move float_format/double_format to _PyRuntimeState.
ericsnowcurrently Nov 15, 2022
bd1a66d
Special-case the hash secret.
ericsnowcurrently Nov 15, 2022
1da0a33
Re-organize the ingored list.
ericsnowcurrently Nov 15, 2022
03481e2
Drop an old global from the ingored list.
ericsnowcurrently Nov 15, 2022
e50ea07
Only initialize bloom_linebreak once in the process.
ericsnowcurrently Nov 15, 2022
a55e26a
Clarify an ignore list header.
ericsnowcurrently Nov 15, 2022
fd3ec40
Move memo_statistics to the ignored list.
ericsnowcurrently Nov 15, 2022
d04d9da
runtime.unicode_ids -> runtime.unicode_state.ids.
ericsnowcurrently Nov 15, 2022
4e13ded
Move force_ascii to _PyRuntimeState.
ericsnowcurrently Nov 15, 2022
e8ad283
Move _Py_PackageContext to _PyRuntimeState.
ericsnowcurrently Nov 15, 2022
22135f7
Move _Py_FatalErrorFormat():reentrant to the ignored list.
ericsnowcurrently Nov 15, 2022
426b34e
Move PyFPE_counter to the ignored list.
ericsnowcurrently Nov 15, 2022
ffdd34a
Move _Py_UnhandledKeyboardInterrupt to _PyRuntimeState.
ericsnowcurrently Nov 15, 2022
248a69c
Fix pyhash_runtime_state on Windows.
ericsnowcurrently Nov 15, 2022
a4a55d1
Fix pyhash_runtime_state on Windows.
ericsnowcurrently Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only initialize bloom_linebreak once in the process.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Nov 15, 2022
commit e50ea0757b91ff7e1537599683b1324899fcc5dd
17 changes: 14 additions & 3 deletions Objects/unicodeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14491,12 +14491,14 @@ PyTypeObject PyUnicode_Type = {

/* Initialize the Unicode implementation */

void
_PyUnicode_InitState(PyInterpreterState *interp)
static void
_init_global_state(void)
{
if (!_Py_IsMainInterpreter(interp)) {
static int initialized = 0;
if (initialized) {
return;
}
initialized = 1;

/* initialize the linebreak bloom filter */
const Py_UCS2 linebreak[] = {
Expand All @@ -14514,6 +14516,15 @@ _PyUnicode_InitState(PyInterpreterState *interp)
Py_ARRAY_LENGTH(linebreak));
}

void
_PyUnicode_InitState(PyInterpreterState *interp)
{
if (!_Py_IsMainInterpreter(interp)) {
return;
}
_init_global_state();
}


PyStatus
_PyUnicode_InitGlobalObjects(PyInterpreterState *interp)
Expand Down
5 changes: 2 additions & 3 deletions Tools/c-analyzer/cpython/ignored.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ Python/fileutils.c set_inheritable ioctl_works -
Objects/longobject.c long_from_non_binary_base log_base_BASE -
Objects/longobject.c long_from_non_binary_base convwidth_base -
Objects/longobject.c long_from_non_binary_base convmultmax_base -
Objects/unicodeobject.c - bloom_linebreak -
Objects/unicodeobject.c _init_global_state initialized -

# XXX Move to _PyRuntimeState?
Parser/action_helpers.c _PyPegen_dummy_name cache -
Expand Down Expand Up @@ -112,9 +114,6 @@ Python/frozen.c - PyImport_FrozenModules -
Python/import.c - inittab_copy -
Python/import.c - PyImport_Inittab -

# initialized during init
Objects/unicodeobject.c - bloom_linebreak -

# used temporarily during init
Python/sysmodule.c - _preinit_warnoptions -
Python/sysmodule.c - _preinit_xoptions -
Expand Down