Skip to content

GH-81057: remove static state from suggestions.c #99411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 4 commits into from
Nov 30, 2022
Merged

GH-81057: remove static state from suggestions.c #99411

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1153e99
remove static state from suggestions
kumaraditya303 Nov 12, 2022
819e051
use heap for buffer
kumaraditya303 Nov 13, 2022
0dfd101
fix error handling
kumaraditya303 Nov 13, 2022
4a43064
Merge branch 'main' of https://github.com/python/cpython into suggest…
kumaraditya303 Nov 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
remove static state from suggestions
  • Loading branch information
@kumaraditya303
kumaraditya303 authored Nov 12, 2022
commit 1153e99fa8ae4793a19fe7fcffe9c28bf0552ffe
4 changes: 2 additions & 2 deletions Python/suggestions.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ levenshtein_distance(const char *a, size_t a_size,
const char *b, size_t b_size,
size_t max_cost)
{
static size_t buffer[MAX_STRING_SIZE];
Comment thread
kumaraditya303 marked this conversation as resolved.
size_t buffer[MAX_STRING_SIZE] = {0};
Comment thread
kumaraditya303 marked this conversation as resolved.
Outdated
Comment thread
kumaraditya303 marked this conversation as resolved.
Outdated

// Both strings are the same (by identity)
if (a == b) {
Expand Down Expand Up @@ -238,7 +238,7 @@ get_suggestions_for_name_error(PyObject* name, PyFrameObject* frame)
if (!self) {
goto error;
}

if (PyObject_HasAttr(self, name)) {
Py_DECREF(dir);
return PyUnicode_FromFormat("self.%S", name);
Expand Down