Skip to content

gh-99377: Add audit events for thread creation and clear #99378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 6 commits into from
Nov 16, 2022
Merged

gh-99377: Add audit events for thread creation and clear #99378

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5c53261
gh-99377: Add audit events for thread creation and clear
zooba Nov 11, 2022
09f0fdf
Only call Python hooks when GIL is held
zooba Nov 11, 2022
9d69a0e
Tries raising the event from a different place, and adds id
zooba Nov 15, 2022
76ef621
Fix tests
zooba Nov 15, 2022
1ff0cde
Revert whitespace changes
zooba Nov 15, 2022
e67161c
Revert GIL check
zooba Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only call Python hooks when GIL is held
  • Loading branch information
@zooba
zooba committed Nov 11, 2022
commit 09f0fdf0d6882573961a3de6d3ccf27924182e8f
3 changes: 2 additions & 1 deletion Python/pystate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,8 @@ new_threadstate(PyInterpreterState *interp)
PyThreadState *tstate;
_PyRuntimeState *runtime = interp->runtime;

if (PySys_Audit("cpython.PyThreadState_New", NULL) < 0) {
PyThreadState *ts = _PyThreadState_GET();
if (ts && _PySys_Audit(ts, "cpython.PyThreadState_New", NULL) < 0) {
return NULL;
}

Expand Down
4 changes: 2 additions & 2 deletions Python/sysmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,8 @@ sys_audit_tstate(PyThreadState *ts, const char *event,
PyDTrace_AUDIT(event, (void *)eventArgs);
}

/* Call interpreter hooks */
if (is->audit_hooks) {
/* Call interpreter hooks if the GIL is held */
if (PyGILState_Check() && is->audit_hooks) {
Comment thread
zooba marked this conversation as resolved.
Outdated
eventName = PyUnicode_FromString(event);
if (!eventName) {
goto exit;
Expand Down