Skip to content

GH-90699: disallow _Py_IDENTIFIER in core code #99210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 3 commits into from
Nov 9, 2022
Merged

GH-90699: disallow _Py_IDENTIFIER in core code #99210

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
886ea7b
disallow _Py_IDENTIFIER
kumaraditya303 Nov 7, 2022
4609aab
Merge branch 'main' of https://github.com/python/cpython into disable-id
kumaraditya303 Nov 9, 2022
aa158d1
add comment
kumaraditya303 Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add comment
  • Loading branch information
@kumaraditya303
kumaraditya303 authored Nov 9, 2022
commit aa158d1a04e6a91d1a763a3b73382091c6ed9ea2
3 changes: 3 additions & 0 deletions Programs/_testembed.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1891,6 +1891,9 @@ static int test_unicode_id_init(void)
// bpo-42882: Test that _PyUnicode_FromId() works
// when Python is initialized multiples times.

// This is equivalent to `_Py_IDENTIFIER(test_unicode_id_init)`
// but since `_Py_IDENTIFIER` is disabled when `Py_BUILD_CORE`
// is defined, it is manually expanded here.
static _Py_Identifier PyId_test_unicode_id_init = {
.string = "test_unicode_id_init",
.index = -1,
Expand Down