Skip to content

bpo-34995: Maintain func.__isabstractmethod__ in functools.cached_property #9904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mwilbz wants to merge 6 commits into from
Closed

bpo-34995: Maintain func.__isabstractmethod__ in functools.cached_property #9904

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
da3ec33
bpo-34995: Maintain func.__isabstractmethod__ in functools.cached_pro…
Oct 15, 2018
bfdc249
Add news entry
Oct 15, 2018
16c0372
Only set __isabstractmethod__ if wrapapped func sets it
Oct 25, 2018
db8dcd7
Check for __isabstractmethod__ with try/except
Oct 25, 2018
1c91dd2
Add negative test case for abstract cached_property
Oct 25, 2018
511c14f
Avoid long lines
Oct 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Lib/functools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,6 +882,10 @@ def __init__(self, func):
self.func = func
self.attrname = None
self.__doc__ = func.__doc__
try:
self.__isabstractmethod__ = func.__isabstractmethod__
except AttributeError:
pass
self.lock = RLock()

def __set_name__(self, owner, name):
Expand Down
11 changes: 11 additions & 0 deletions Lib/test/test_functools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2478,6 +2478,17 @@ def test_access_from_class(self):
def test_doc(self):
self.assertEqual(CachedCostItem.cost.__doc__, "The cost of the item.")

def test_isabstractmethod(self):
class AbstractExpensiveCalculator(abc.ABC):
@functools.cached_property
@abc.abstractmethod
def calculate(self):
pass

self.assertTrue(getattr(AbstractExpensiveCalculator.calculate, '__isabstractmethod__', False))

@vstinner vstinner Oct 25, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.assertTrue(AbstractExpensiveCalculator.calculate.isabstractmethod) is enough.

with self.assertRaises(TypeError):

@vstinner vstinner Oct 25, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to (also) directly check the isabstractmethod attribute?

@mwilbz mwilbz Oct 25, 2018

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion, added an assertion for that

AbstractExpensiveCalculator()

@vstinner vstinner Oct 25, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test on a method which doesn't have the __isabstractmethod__ attribute? I expect such test:

self.assertFalse(hasattr(AbstractExpensiveCalculator.calculate, '__isabstractmethod__'))


if __name__ == '__main__':
unittest.main()
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2018-10-15-23-56-39.bpo-34995.kNA9ge.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Maintain wrapped method's __isabstractmethod__ in functools.cached_property

@vstinner vstinner Oct 25, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest:

:func:`functools.cached_property` now also copies the wrapped method's ``__isabstractmethod__`` attribute.